-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Concurrency 3.1 - Add virtual and qualifier elements to resource definitions #44
Conversation
</context-service> | ||
|
||
<managed-executor> | ||
<name>java:app/concurrent/Executor20</name> | ||
<context-service-ref>java:app/concurrent/SecContextOnly</context-service-ref> | ||
<max-async>20</max-async> | ||
<qualifier>ee.jakarta.MyQualifier</qualifier> | ||
<qualifier>ee.jakarta.MyQualifier2</qualifier> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ordering of the elements in the application_11.xsd for the managed-executorType has the virtual element before the qualifier element, which is why you are seeing validation errors.
@starksm64 thanks for catching that! I updated the test to have elements in the correct order. I also updated the web-app-concurrency test which required me to copy/rename the web-app related schemas. I also want to update the ejb-jar-concurrency test, which would mean we'd have to update the ejb-jar schema to change the following to EE 11:
However there are no new versions of EJB for EE 10/11, so how can embedded resources within this schema be included? Reading some more issues it seems the determination is that EJB schema is frozen at EE 9. Therefore I removed the ejb-jar-concurrency test because it is invalid. FYI @tbitonti - This may be of interest to you based on your issue #32 |
bfe3b2f
to
9b60b31
Compare
So we won't be able to update the ejb-jar-concurrency.xml test since we don't have any updated schema and there will be no requirements for EJB containers to support the new environments. |
We should consider positioning the new |
@ivargrimstad @starksm64 anything else I need to do to get this PR reviewed/approved? |
How to Publish XML Schemas -- Sorry for the wrong link. It seems to incorrect in several places. I'll update the templates (and a few other places where I noticed this). |
Fixes #43
NOTE: testing locally and via GitHub actions resulted in the following error:
Not sure what this failure means. If someone more familiar with this project could point me in the right direction it would be appreciated.
(Also weird that errors don't cause build breaks 🤷🏼 )