Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added GlassFish's bootstrap modulepath #1685

Draft
wants to merge 1 commit into
base: 10.0.x
Choose a base branch
from

Conversation

dmatej
Copy link
Contributor

@dmatej dmatej commented Dec 4, 2024

  • Will come with Glassfish 7.1.0

Related Issue(s)

Describe the change

  • Especially appclient based tests explicitly use Glassfish classes to run the client, they have to specify classpath, required system options, etc - and also modulepath introduced in JDK11 but not used until GlassFish 7.1.0.
  • The bootstrap module path contains several jar files between JDK and GlassFish and it is fully JPMS enabled.

Additional Context

  • The classpath of the appclient could be simplified in the TCK just like in GlassFish 7.1.0, however I doubt anyone would like to spend time with that for this TCK version.
  • I am slowly running TCK tests for the future GF 7.1.0-SNAPSHOT, currently it locally passes ejb32 and persistence.
  • I am waiting for a new hardware, then verifying all tests against two GF versions (7.0.20 and 7.1.0-SNAPSHOT) should be a thing of one or two days.

CC @alwin-joseph @anajosep @arjantijms @cesarhernandezgt @dblevins @m0mus @edbratt @gurunrao @jansupol @jgallimore @kazumura @kwsutter @LanceAndersen @bhatpmk @RohitKumarJain @shighbar @gthoman @brideck @OndroMih @dmatej
@starksm64 @scottmarlow

- Will come with Glassfish 7.1.0

Signed-off-by: David Matějček <[email protected]>
@dmatej dmatej added the enhancement New feature or request label Dec 4, 2024
@dmatej dmatej added this to the 10.0.6 milestone Dec 4, 2024
@dmatej dmatej requested a review from a team December 4, 2024 16:27
@dmatej dmatej self-assigned this Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant