Improved error messages in examples.

jamesiarmes · Jan 22, 2017 · 59ad8ce · 59ad8ce
1 parent e61c16e
commit 59ad8ce
Show file tree

Hide file tree

Showing 28 changed files with 115 additions and 59 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -9,6 +9,7 @@
 - Fixed Exchange 2007 version parsing in autodiscovery.
 - Fixed event title in event/create example.
 - Fixed capitalization of URL property on PushSubscriptionRequestType.
+- Improved error messages in examples.
 
 ## 1.0.0-beta.2 - 2017-01-12
 

diff --git a/examples/contact/create.php b/examples/contact/create.php
@@ -86,8 +86,9 @@
 foreach ($response_messages as $response_message) {
     // Make sure the request succeeded.
     if ($response_message->ResponseClass != ResponseClassType::SUCCESS) {
-        $message = $response_message->ResponseCode;
-        fwrite(STDERR, "Contact failed to create with \"$message\"\n");
+        $code = $response_message->ResponseCode;
+        $message = $response_message->MessageText;
+        fwrite(STDERR, "Contact failed to create with \"$code: $message\"\n");
         continue;
     }
 

diff --git a/examples/contact/describe.php b/examples/contact/describe.php
@@ -46,8 +46,9 @@
 foreach ($response_messages as $response_message) {
     // Make sure the request succeeded.
     if ($response_message->ResponseClass != ResponseClassType::SUCCESS) {
-        $message = $response_message->ResponseCode;
-        fwrite(STDERR, "Failed to get contact with \"$message\"\n");
+        $code = $response_message->ResponseCode;
+        $message = $response_message->MessageText;
+        fwrite(STDERR, "Failed to get contact with \"$code: $message\"\n");
         continue;
     }
 

diff --git a/examples/contact/find.php b/examples/contact/find.php
@@ -37,8 +37,12 @@
 foreach ($response_messages as $response_message) {
     // Make sure the request succeeded.
     if ($response_message->ResponseClass != ResponseClassType::SUCCESS) {
-        $message = $response_message->ResponseCode;
-        fwrite(STDERR, "Failed to search for contacts with \"$message\"\n");
+        $code = $response_message->ResponseCode;
+        $message = $response_message->MessageText;
+        fwrite(
+            STDERR,
+            "Failed to search for contacts with \"$code: $message\"\n"
+        );
         continue;
     }
 

diff --git a/examples/contact/set-photo.php b/examples/contact/set-photo.php
@@ -55,8 +55,12 @@
 foreach ($response_messages as $response_message) {
     // Make sure the request succeeded.
     if ($response_message->ResponseClass != ResponseClassType::SUCCESS) {
-        $message = $response_message->ResponseCode;
-        fwrite(STDERR, "Failed to create attachment with \"$message\"\n");
+        $code = $response_message->ResponseCode;
+        $message = $response_message->MessageText;
+        fwrite(
+            STDERR,
+            "Failed to create attachment with \"$code: $message\"\n"
+        );
         continue;
     }
 

diff --git a/examples/contact/update.php b/examples/contact/update.php
@@ -85,8 +85,9 @@
 foreach ($response_messages as $response_message) {
     // Make sure the request succeeded.
     if ($response_message->ResponseClass != ResponseClassType::SUCCESS) {
-        $message = $response_message->ResponseCode;
-        fwrite(STDERR, "Failed to update contact with \"$message\"\n");
+        $code = $response_message->ResponseCode;
+        $message = $response_message->MessageText;
+        fwrite(STDERR, "Failed to update contact with \"$code: $message\"\n");
         continue;
     }
 

diff --git a/examples/event/cancel.php b/examples/event/cancel.php
@@ -47,8 +47,12 @@
 foreach ($response_messages as $response_message) {
     // Make sure the request succeeded.
     if ($response_message->ResponseClass != ResponseClassType::SUCCESS) {
-        $message = $response_message->ResponseCode;
-        fwrite(STDERR, "Cancellation failed to create with \"$message\"\n");
+        $code = $response_message->ResponseCode;
+        $message = $response_message->MessageText;
+        fwrite(
+            STDERR,
+            "Cancellation failed to create with \"$code: $message\"\n"
+        );
         continue;
     }
 }
diff --git a/examples/event/create.php b/examples/event/create.php
@@ -77,8 +77,9 @@
 foreach ($response_messages as $response_message) {
     // Make sure the request succeeded.
     if ($response_message->ResponseClass != ResponseClassType::SUCCESS) {
-        $message = $response_message->ResponseCode;
-        fwrite(STDERR, "Event failed to create with \"$message\"\n");
+        $code = $response_message->ResponseCode;
+        $message = $response_message->MessageText;
+        fwrite(STDERR, "Event failed to create with \"$code: $message\"\n");
         continue;
     }
 

diff --git a/examples/event/find.php b/examples/event/find.php
@@ -51,8 +51,12 @@
 foreach ($response_messages as $response_message) {
     // Make sure the request succeeded.
     if ($response_message->ResponseClass != ResponseClassType::SUCCESS) {
-        $message = $response_message->ResponseCode;
-        fwrite(STDERR, "Failed to search for events with \"$message\"\n");
+        $code = $response_message->ResponseCode;
+        $message = $response_message->MessageText;
+        fwrite(
+            STDERR,
+            "Failed to search for events with \"$code: $message\"\n"
+        );
         continue;
     }
 

diff --git a/examples/event/sync.php b/examples/event/sync.php
@@ -55,11 +55,9 @@
 foreach ($response_messages as $response_message) {
     // Make sure the request succeeded.
     if ($response_message->ResponseClass != ResponseClassType::SUCCESS) {
-        $message = $response_message->ResponseCode;
-        fwrite(STDERR, "Failed to sync folder with \"$message\"\n");
-
-        $soap = $client->getClient();
-        $lr = $soap->__getLastRequest();
+        $code = $response_message->ResponseCode;
+        $message = $response_message->MessageText;
+        fwrite(STDERR, "Failed to sync folder with \"$code: $message\"\n");
         continue;
     }
 

diff --git a/examples/event/update.php b/examples/event/update.php
@@ -80,8 +80,9 @@
 foreach ($response_messages as $response_message) {
     // Make sure the request succeeded.
     if ($response_message->ResponseClass != ResponseClassType::SUCCESS) {
-        $message = $response_message->ResponseCode;
-        fwrite(STDERR, "Failed to update event with \"$message\"\n");
+        $code = $response_message->ResponseCode;
+        $message = $response_message->MessageText;
+        fwrite(STDERR, "Failed to update event with \"$code: $message\"\n");
         continue;
     }
 

diff --git a/examples/folder/create.php b/examples/folder/create.php
@@ -53,8 +53,9 @@
 foreach ($response_messages as $response_message) {
     // Make sure the request succeeded.
     if ($response_message->ResponseClass != ResponseClassType::SUCCESS) {
-        $message = $response_message->ResponseCode;
-        fwrite(STDERR, "Folder failed to create with \"$message\"\n");
+        $code = $response_message->ResponseCode;
+        $message = $response_message->MessageText;
+        fwrite(STDERR, "Folder failed to create with \"$code: $message\"\n");
         continue;
     }
 

diff --git a/examples/folder/delete.php b/examples/folder/delete.php
@@ -47,8 +47,9 @@
 foreach ($response_messages as $response_message) {
     // Make sure the request succeeded.
     if ($response_message->ResponseClass != ResponseClassType::SUCCESS) {
-        $message = $response_message->ResponseCode;
-        fwrite(STDERR, "Folder failed to delete with \"$message\"\n");
+        $code = $response_message->ResponseCode;
+        $message = $response_message->MessageText;
+        fwrite(STDERR, "Folder failed to delete with \"$code: $message\"\n");
         continue;
     }
 }
diff --git a/examples/folder/find.php b/examples/folder/find.php
@@ -66,8 +66,9 @@
 foreach ($response_messages as $response_message) {
     // Make sure the request succeeded.
     if ($response_message->ResponseClass != ResponseClassType::SUCCESS) {
-        $message = $response_message->ResponseCode;
-        fwrite(STDERR, "Failed to find folders with \"$message\"\n");
+        $code = $response_message->ResponseCode;
+        $message = $response_message->MessageText;
+        fwrite(STDERR, "Failed to find folders with \"$code: $message\"\n");
         continue;
     }
 

diff --git a/examples/message/add-attachment.php b/examples/message/add-attachment.php
@@ -55,8 +55,12 @@
 foreach ($response_messages as $response_message) {
     // Make sure the request succeeded.
     if ($response_message->ResponseClass != ResponseClassType::SUCCESS) {
-        $message = $response_message->ResponseCode;
-        fwrite(STDERR, "Failed to create attachment with \"$message\"\n");
+        $code = $response_message->ResponseCode;
+        $message = $response_message->MessageText;
+        fwrite(
+            STDERR,
+            "Failed to create attachment with \"$code: $message\"\n"
+        );
         continue;
     }
 

diff --git a/examples/message/create.php b/examples/message/create.php
@@ -78,8 +78,9 @@
 foreach ($response_messages as $response_message) {
     // Make sure the request succeeded.
     if ($response_message->ResponseClass != ResponseClassType::SUCCESS) {
-        $message = $response_message->ResponseCode;
-        fwrite(STDERR, "Message failed to create with \"$message\"\n");
+        $code = $response_message->ResponseCode;
+        $message = $response_message->MessageText;
+        fwrite(STDERR, "Message failed to create with \"$code: $message\"\n");
         continue;
     }
 

diff --git a/examples/message/describe.php b/examples/message/describe.php
@@ -59,8 +59,9 @@
 foreach ($response_messages as $response_message) {
     // Make sure the request succeeded.
     if ($response_message->ResponseClass != ResponseClassType::SUCCESS) {
-        $message = $response_message->ResponseCode;
-        fwrite(STDERR, "Failed to get message with \"$message\"\n");
+        $code = $response_message->ResponseCode;
+        $message = $response_message->MessageText;
+        fwrite(STDERR, "Failed to get message with \"$code: $message\"\n");
         continue;
     }
 

diff --git a/examples/message/find.php b/examples/message/find.php
@@ -77,8 +77,12 @@
 foreach ($response_messages as $response_message) {
     // Make sure the request succeeded.
     if ($response_message->ResponseClass != ResponseClassType::SUCCESS) {
-        $message = $response_message->ResponseCode;
-        fwrite(STDERR, "Failed to search for messages with \"$message\"\n");
+        $code = $response_message->ResponseCode;
+        $message = $response_message->MessageText;
+        fwrite(
+            STDERR,
+            "Failed to search for messages with \"$code: $message\"\n"
+        );
         continue;
     }
 

diff --git a/examples/message/get-attachments.php b/examples/message/get-attachments.php
@@ -63,8 +63,9 @@
 foreach ($response_messages as $response_message) {
     // Make sure the request succeeded.
     if ($response_message->ResponseClass != ResponseClassType::SUCCESS) {
-        $message = $response_message->ResponseCode;
-        fwrite(STDERR, "Failed to get message with \"$message\"\n");
+        $code = $response_message->ResponseCode;
+        $message = $response_message->MessageText;
+        fwrite(STDERR, "Failed to get message with \"$code: $message\"\n");
         continue;
     }
 
@@ -104,8 +105,12 @@
         // Make sure the request succeeded.
         if ($attachment_response_message->ResponseClass
             != ResponseClassType::SUCCESS) {
-            $message = $attachment_response_message->ResponseCode;
-            fwrite(STDERR, "Failed to get attachment with \"$message\"\n");
+            $code = $response_message->ResponseCode;
+            $message = $response_message->MessageText;
+            fwrite(
+                STDERR,
+                "Failed to get attachment with \"$code: $message\"\n"
+            );
             continue;
         }
 

diff --git a/examples/message/paging.php b/examples/message/paging.php
@@ -64,8 +64,12 @@
 foreach ($response_messages as $response_message) {
     // Make sure the request succeeded.
     if ($response_message->ResponseClass != ResponseClassType::SUCCESS) {
-        $message = $response_message->ResponseCode;
-        fwrite(STDERR, "Failed to search for messages with \"$message\"\n");
+        $code = $response_message->ResponseCode;
+        $message = $response_message->MessageText;
+        fwrite(
+            STDERR,
+            "Failed to search for messages with \"$code: $message\"\n"
+        );
         continue;
     }
 

diff --git a/examples/message/reply-all.php b/examples/message/reply-all.php
@@ -54,8 +54,9 @@
 foreach ($response_messages as $response_message) {
     // Make sure the request succeeded.
     if ($response_message->ResponseClass != ResponseClassType::SUCCESS) {
-        $message = $response_message->ResponseCode;
-        fwrite(STDERR, "Reply failed to create with \"$message\"\n");
+        $code = $response_message->ResponseCode;
+        $message = $response_message->MessageText;
+        fwrite(STDERR, "Reply failed to create with \"$code: $message\"\n");
         continue;
     }
 

diff --git a/examples/message/send.php b/examples/message/send.php
@@ -55,8 +55,9 @@
 foreach ($response_messages as $response_message) {
     // Make sure the request succeeded.
     if ($response_message->ResponseClass != ResponseClassType::SUCCESS) {
-        $message = $response_message->ResponseCode;
-        fwrite(STDERR, "Message failed to send with \"$message\"\n");
+        $code = $response_message->ResponseCode;
+        $message = $response_message->MessageText;
+        fwrite(STDERR, "Message failed to send with \"$code: $message\"\n");
         continue;
     }
 

diff --git a/examples/system/timezone-definitions.php b/examples/system/timezone-definitions.php
@@ -40,8 +40,9 @@
 foreach ($response_messages as $response_message) {
     // Make sure the request succeeded.
     if ($response_message->ResponseClass != ResponseClassType::SUCCESS) {
-        $message = $response_message->ResponseCode;
-        fwrite(STDERR, "Failed to get timezones with \"$message\"\n");
+        $code = $response_message->ResponseCode;
+        $message = $response_message->MessageText;
+        fwrite(STDERR, "Failed to get timezones with \"$code: $message\"\n");
         continue;
     }
 

diff --git a/examples/user/category-list.php b/examples/user/category-list.php
@@ -42,10 +42,11 @@
 foreach ($response_messages as $response_message) {
     // Make sure the request succeeded.
     if ($response_message->ResponseClass != ResponseClassType::SUCCESS) {
-        $message = $response_message->ResponseCode;
+        $code = $response_message->ResponseCode;
+        $message = $response_message->MessageText;
         fwrite(
             STDERR,
-            "Failed to get User Configuration with \"$message\"\n"
+            "Failed to get User Configuration with \"$code: $message\"\n"
         );
         continue;
     }

diff --git a/examples/user/free-busy.php b/examples/user/free-busy.php
@@ -67,8 +67,12 @@
     // Make sure the request succeeded.
     $response_message = $availability->ResponseMessage;
     if ($response_message->ResponseClass != ResponseClassType::SUCCESS) {
-        $message = $response_message->ResponseCode;
-        fwrite(STDERR, "Failed to get user availability with \"$message\"\n");
+        $code = $response_message->ResponseCode;
+        $message = $response_message->MessageText;
+        fwrite(
+            STDERR,
+            "Failed to get user availability with \"$code: $message\"\n"
+        );
         continue;
     }
 

diff --git a/examples/user/get-configuration.php b/examples/user/get-configuration.php
@@ -41,10 +41,11 @@
 foreach ($response_messages as $response_message) {
     // Make sure the request succeeded.
     if ($response_message->ResponseClass != ResponseClassType::SUCCESS) {
-        $message = $response_message->ResponseCode;
+        $code = $response_message->ResponseCode;
+        $message = $response_message->MessageText;
         fwrite(
             STDERR,
-            "Failed to get User Configuration with \"$message\"\n"
+            "Failed to get User Configuration with \"$code: $message\"\n"
         );
         continue;
     }

diff --git a/examples/user/meeting-suggestions.php b/examples/user/meeting-suggestions.php
@@ -72,8 +72,12 @@
 // Make sure the request succeeded.
 $response_message = $response->SuggestionsResponse->ResponseMessage;
 if ($response_message->ResponseClass != ResponseClassType::SUCCESS) {
-    $message = $response_message->ResponseCode;
-    fwrite(STDERR, "Failed to get user availability with \"$message\"\n");
+    $code = $response_message->ResponseCode;
+    $message = $response_message->MessageText;
+    fwrite(
+        STDERR,
+        "Failed to get user availability with \"$code: $message\"\n"
+    );
     exit;
 }
 

diff --git a/examples/user/update-configuration.php b/examples/user/update-configuration.php
@@ -101,10 +101,11 @@
 foreach ($response_messages as $response_message) {
     // Make sure the request succeeded.
     if ($response_message->ResponseClass != ResponseClassType::SUCCESS) {
-        $message = $response_message->ResponseCode;
+        $code = $response_message->ResponseCode;
+        $message = $response_message->MessageText;
         fwrite(
             STDERR,
-            "User Configuration failed to update with \"$message\"\n"
+            "User Configuration failed to update with \"$code: $message\"\n"
         );
         continue;
     }