Auto register events #150
Auto register events #150
Conversation
| /// <param name="services"></param> | ||
| /// <param name="assemblies"></param> | ||
| /// <returns></returns> | ||
| public static IServiceCollection AddEventsFromAssemblies(this IServiceCollection services, params Assembly[] assemblies) |
There was a problem hiding this comment.
I think it would be much simpler to take the logic you had placed in the AssemblyScanner class and inline it as one of the these service methods (private).
We should expose one method that will scan all loaded assemblies and auto-register them all at once. That way the client doesn't need to manually specify what assemblies they want to use. We'll just scan them all.
Coravel Pro does something like this to auto-register all invocables:
GetAllTypesOfType<IInvocable>()
.Distinct()
.ToList()
.ForEach(i => services.AddTransient(i));If you have any thoughts or I missed something please let me know 👍
There was a problem hiding this comment.
That makes sense, I'll make the changes in the coming days. I was a bit too locked in on the proposed implementation (with two different calls) that I didn't stop to consider an easier way 🙂
There was a problem hiding this comment.
It's all good. Thanks! No rush 😊
Implementation for #148
I went back and forth between a few different approaches but I think this is the one I'm happiest with. Any feedback is much appreciated.