Narrow detect_changes to be able to specify owner #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamie-pate
requested changes
Dec 20, 2024
|
|
||
|
|
||
| func _detect_changes(): | ||
| func _detect_changes(ancestor: Node): | ||
| # TODO: queue change detection per viewport root or control root? |
There was a problem hiding this comment.
This implements change detection per control root, that part of the TODO should be removed
| @@ -9,14 +9,14 @@ var _change_detection_queued := false | |||
|
|
|||
|
|
|||
| ## queue change detection | |||
| func detect_changes() -> void: | |||
| func detect_changes(ancestor: Node = null) -> void: | |||
| if _change_detection_queued: | |||
| return | |||
| _change_detection_queued = true | |||
There was a problem hiding this comment.
_change_detection_queued is no longer valid if you can call it with different arguments. it now needs to be a list of nodes which have requested change detection.
Since change detection happens on a subsequent frame, we would need some kind of weak node reference to avoid use after free
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simply filters for bindings that have the specified node as an ancestor
Implements #2