Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add eslint to normalize code style #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

XatMassacrE
Copy link

Maybe it's not a problem for one person, but i think a uniform code style is important for collaborating.
So i add airbnb to normalize code, but i find warnings and errors are too much that i finally comment it.
But i reserve the basic config so you can custom your own code style.
By the way, webpack 2 replace loaders with rules, and i fix it.

@janhuenermann
Copy link
Owner

Thanks, this is great! Def need some kind of uniform code style, agree! But I don't have any experience with eslint or airbnb. Let me read about these tools first, before changing the code base/code style.

@andrewgremlich
Copy link

@janhuenermann you could definitely set the contribution criteria seeing as you started the repo.

Have you figured out eslint yet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants