-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #384 - Add a percentage and current limit when running in report mode #588
Open
derrix060
wants to merge
2
commits into
jantman:develop
Choose a base branch
from
derrix060:develop
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
The idea here is to improve the visualization of the reporting by adding not only the usage, but the limit and how close to the limit it is. Also, to make it easier to read, print it all in a table format. Example before: ``` EC2/All F Spot Instance Requests 0 EC2/All G Spot Instance Requests 0 EC2/All Inf Spot Instance Requests 0 EC2/All P Spot Instance Requests 0 EC2/All Standard (A, C, D, H, I, M, R, T, Z) Spot Instance Requests 0 EC2/All X Spot Instance Requests 0 EC2/Elastic IP addresses (EIPs) 0 EC2/Max active spot fleets per region 0 EC2/Max launch specifications per spot fleet <unknown> EC2/Max target capacity for all spot fleets in region 0 EC2/Max target capacity per spot fleet <unknown> EC2/Rules per VPC security group max: sg-0648da97fdeebf980=102 (sg-0df2ad106237174ea=1, sg-07e5e4f72cea0dfe5=1, sg-0b9911c871252d8e7=1, sg-0d055747ec7c4140e=1, sg-09551693a5250b7f4=1, sg-0781c381e1b5d378a=1, sg-0fd94d543ec6cf4ee=1, sg-05e714614de7941cd=1, sg-03cc3b695a6366ffd=1, sg-083eae2676c6f8b92=1, sg-0dc2ee2f21505bf2c=1, sg-0e1729f5b07df6416=1, sg-0de5f793ac0da38e7=1, sg-0d79228bbb3f97b6d=1, sg-0c7bcbb474d8afbf5=1, sg-0d6aa6e6209d923b5=1, sg-086b6c19c0860460b=1, sg-0c56e7af849a12622=1, sg-086a3c13d414aef8b=1, sg-0853c55cd9df708de=1, sg-0e1ed9e1ceca720a1=1, sg-099ef683e4d35e2ee=1, sg-0adc28eb7faa40ecf=1, sg-0dabf1e2c30f5998f=1, sg-06aedf016149fbe14=1, sg-0f9148df50a48a291=1, sg-006e95a00de69f1b8=1, sg-0f9f697bf9ef106a5=1, ``` Example after: ``` ┌──────────────────────────────────────────────────────────────────────────┬───────────────────────┬───────────┬───────────┬───────────┐ │ Service Limit │ Resource │ Usage # │ Usage % │ Limit │ ├──────────────────────────────────────────────────────────────────────────┼───────────────────────┼───────────┼───────────┼───────────┤ │ EC2/All F Spot Instance Requests │ - │ 0 │ 0 % │ 128 │ │ EC2/All G Spot Instance Requests │ - │ 0 │ - │ <unknown> │ │ EC2/All Inf Spot Instance Requests │ - │ 0 │ 0 % │ 64 │ │ EC2/All P Spot Instance Requests │ - │ 0 │ - │ <unknown> │ │ EC2/All Standard (A, C, D, H, I, M, R, T, Z) Spot Instance Requests │ - │ 0 │ 0 % │ 640 │ │ EC2/All X Spot Instance Requests │ - │ 0 │ 0 % │ 128 │ │ EC2/Elastic IP addresses (EIPs) │ - │ 0 │ - │ <unknown> │ │ EC2/Max active spot fleets per region │ - │ 0 │ - │ <unknown> │ │ EC2/Max target capacity for all spot fleets in region │ - │ 0 │ - │ <unknown> │ │ EC2/Rules per VPC security group │ sg-058d83cc259d4e69c │ 3 │ 2 % │ 120 │ │ EC2/Rules per VPC security group │ sg-0783065c4d2b78c83 │ 3 │ 2 % │ 120 │ │ EC2/Rules per VPC security group │ sg-0df2ad106237174ea │ 1 │ 1 % │ 120 │ │ EC2/Rules per VPC security group │ sg-07e5e4f72cea0dfe5 │ 1 │ 1 % │ 120 │ │ EC2/Rules per VPC security group │ sg-0b9911c871252d8e7 │ 1 │ 1 % │ 120 │ │ EC2/Rules per VPC security group │ sg-0229a5ed0b61ce2bd │ 2 │ 2 % │ 120 │ │ EC2/Rules per VPC security group │ sg-0b25ba5186ce99117 │ 2 │ 2 % │ 120 │ ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #384
The idea here is to improve the visualization of the reporting
by adding not only the usage, but the limit and how close to the
limit it is.
Also, to make it easier to read, print it all in a table format.
Example before:
Example after:
Pull Request Checklist
writing tests for the code, that's fine, just mention that in the summary and either
ask for assistance, or clarify that you'd like someone else to handle the tests. PRs that
include complete test coverage will usually be merged faster.
tox -e docs
connect()
andconnect_resource()
methods, inherited fromawslimitchecker.connectable.Connectable
if you're working on a GitHub issue (i.e. "issue #x - "). Please
refrain from using the "fixes #x" notation unless you are sure that the
the issue is fixed in that commit.
Contributor License Agreement
By submitting this work for inclusion in awslimitchecker, I agree to the following terms:
is being made under the same license as the awslimitchecker project (the Affero GPL v3,
or any subsequent version of that license if adopted by awslimitchecker).
this pull request grants a perpetual, global, unlimited license for it to be used and distributed
under the terms of awslimitchecker's license.