Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(homepage): wrapper update (incl update @scalprum/react-core from 0.8 to 0.9) #1969

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

christoph-jerolimov
Copy link
Member

@christoph-jerolimov christoph-jerolimov commented Nov 20, 2024

Description

  • This updates the dynamic-home-page dependency to include @kim-tsao PR fix(deps): update dependencies (non-major) #1977 after we migrated the plugin to rhdh-plugins repo.
  • Also removed the default home page and added it to the dynamic-plugins.default.yaml. When a user disables the dynamic home page, also the menu item will disappear automatically.

Which issue(s) does this PR fix

  • Fixes #?

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

Copy link

openshift-ci bot commented Nov 20, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

openshift-ci bot commented Nov 20, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from christoph-jerolimov. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

sonarcloud bot commented Nov 20, 2024

Copy link
Contributor

@christoph-jerolimov christoph-jerolimov marked this pull request as ready for review November 21, 2024 08:25
@christoph-jerolimov christoph-jerolimov requested a review from a team as a code owner November 21, 2024 08:25
@christoph-jerolimov christoph-jerolimov changed the title [WIP] refactor(homepage): migrate from internal dynamic-home-page to rhdh plugin refactor(homepage): migrate from internal dynamic-home-page to rhdh plugin Nov 21, 2024
@christoph-jerolimov
Copy link
Member Author

/retest

1 similar comment
@kim-tsao
Copy link
Member

/retest

@christoph-jerolimov christoph-jerolimov changed the title refactor(homepage): migrate from internal dynamic-home-page to rhdh plugin refactor(homepage): wrapper update (incl update @scalprum/react-core from 0.8 to 0.9) Nov 27, 2024
@christoph-jerolimov christoph-jerolimov self-assigned this Nov 27, 2024
Copy link
Contributor

@christoph-jerolimov christoph-jerolimov changed the title refactor(homepage): wrapper update (incl update @scalprum/react-core from 0.8 to 0.9) fix(homepage): wrapper update (incl update @scalprum/react-core from 0.8 to 0.9) Nov 27, 2024
@christoph-jerolimov
Copy link
Member Author

/retest

@christoph-jerolimov
Copy link
Member Author

/cherry-pick release-1.4

@openshift-cherrypick-robot

@christoph-jerolimov: once the present PR merges, I will cherry-pick it on top of release-1.4 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants