Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create uk_ua.json #1064

Open
wants to merge 3 commits into
base: 1.18
Choose a base branch
from
Open

Create uk_ua.json #1064

wants to merge 3 commits into from

Conversation

MEGATREX4
Copy link

I think it is much more accurate than the one proposed by the other gentleman.

@MEGATREX4
Create uk_ua.json
2bef1b8 
I think it is much more accurate than the one proposed by the other gentleman.
MartianDill
MartianDill suggested changes May 3, 2023
View reviewed changes
Copy link

@MartianDill MartianDill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some possible improvements. Also you should update your pull request and send it to newer version instead of 1.18 (or both at the same time)

src/main/resources/assets/storagedrawers/lang/uk_ua.json Outdated Show resolved Hide resolved
src/main/resources/assets/storagedrawers/lang/uk_ua.json Outdated Show resolved Hide resolved
src/main/resources/assets/storagedrawers/lang/uk_ua.json Outdated Show resolved Hide resolved
src/main/resources/assets/storagedrawers/lang/uk_ua.json Outdated Show resolved Hide resolved
src/main/resources/assets/storagedrawers/lang/uk_ua.json Outdated Show resolved Hide resolved
src/main/resources/assets/storagedrawers/lang/uk_ua.json Outdated Show resolved Hide resolved
src/main/resources/assets/storagedrawers/lang/uk_ua.json Outdated Show resolved Hide resolved
src/main/resources/assets/storagedrawers/lang/uk_ua.json Outdated Show resolved Hide resolved
src/main/resources/assets/storagedrawers/lang/uk_ua.json Outdated Show resolved Hide resolved
src/main/resources/assets/storagedrawers/lang/uk_ua.json Outdated Show resolved Hide resolved
MEGATREX4 added 2 commits May 4, 2023 00:20
@MEGATREX4
Update uk_ua.json
c35ade4 
updated translation
@MEGATREX4
Update uk_ua.json
48932ef 
small bug
@MEGATREX4
Copy link
Author

Added some possible improvements. Also you should update your pull request and send it to newer version instead of 1.18 (or both at the same time)

I'm already using version 1.19

MartianDill
MartianDill approved these changes May 4, 2023
View reviewed changes
Copy link

@MartianDill MartianDill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM:thumbsup:

@MartianDill
Copy link

MartianDill commented May 4, 2023 •
edited
Loading

Added some possible improvements. Also you should update your pull request and send it to newer version instead of 1.18 (or both at the same time)

I'm already using version 1.19

ok, but this Pull Request opened for 1.18 branch, while active is 1.19 branch
I think you should create a new Pull Request for the active branch (maybe with mentioning this PL #1064) so the author will see it and merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartianDill MartianDill MartianDill approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MEGATREX4 @MartianDill