Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes iCal not downloading #63

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixes iCal not downloading #63

wants to merge 1 commit into from

Conversation

alexrabin
Copy link

@alexrabin alexrabin commented Jun 21, 2023 •
edited
Loading

@alexrabin alexrabin changed the title Fixes #35 Fixes #60 Jun 21, 2023
@alexrabin alexrabin changed the title Fixes #60 Fixes iCal not downloading Jun 21, 2023
@wyantb
Copy link
Contributor

wyantb commented Nov 27, 2023 •
edited
Loading

Only thought on this - can the data/text prefixing be put directly into the anchor's href to get things working? Similar to described in https://www.maxkohler.com/posts/calendar-links/ with data:text/calendar;charset=utf-8,BEGIN...

This PR is almost certainly an improvement over what's in master already, however.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexrabin @wyantb