Improve build environment for GoSodium #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 3, 2015 22:34
Instead, rely on environment variables when compiling libsodium when not
found in the default location. For example:
$ env \
C_INCLUDE_PATH=/opt/local/include \
LIBRARY_PATH=/opt/local/lib \
CGO_LDFLAGS='-L/opt/local/lib -lsodium' \
go get github.com/jasonmccampbell/GoSodium
Flesh out the example to explicitly include CGO_CPPFLAGS and CGO_LDFLAGS so future users can just copy/paste and twiddle away.
|
Great work! I was actually planning on doing this with the unit tests, but high school :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes the #cgo directives that hard coded /home/action and relies on the environment variables CGO_CPPFLAGS and CGO_LDFLAGS for building. The README was updated with a copy/paste-able example.