Add support for $wgDiscordAnonymizeIP #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
$wgDiscordAnonymizeIP support
$wgDiscordAnonymizeIP support
|
Hey, thanks for the PR. I don't mind this feature, but I'm wondering if it's better to wait until Wikimedia implements temporary accounts (https://www.mediawiki.org/wiki/Help:Temporary_accounts), which is a change from the current IP-based anonymous user system. I guess it depends how far down the line we're expecting them to release that feature in a MediaWiki update. |
|
Since 1_39 is the latest specified version on the repo, I'd suggest merging this into the 1_39 branch and then make a new branch for the temporary accounts handling (since it's probably going to break other stuff too). Up to you though! Thanks for the awesome extension regardless :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This setting will make it show "Anonymous" instead of an unregistered user's IP address. Meant to be used with AnonPrivacy, but not required.