Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diff null sources #256

Closed
wants to merge 4 commits into from
Closed

Diff null sources #256

wants to merge 4 commits into from

Conversation

hedgar2017
Copy link
Contributor

@hedgar2017 hedgar2017 commented Feb 8, 2019

Resolves the issue

@dariusc93
Copy link
Contributor

What you should do to reduce repeated code is to put

#[cfg(target_os = "windows")]
const NULL_SOURCE: &str = "nul";
#[cfg(target_os = "linux")]
const NULL_SOURCE: &str = "/dev/null";

in text/mod.rs then do use crate::bindings::text::NULL_SOURCE in any code, or maybe put them in one of the crates this crate uses (eg patch?) and include it. Same with PR #258 and maybe #255 ?

@hedgar2017
Copy link
Contributor Author

Merged with PR #258

@hedgar2017 hedgar2017 closed this Feb 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants