Bug fix for race condition and unpredictable presence of DONE packet. #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 8, 2023
This commit addresses two separate issues: 1. There was previously a short window where a message was sent to the netlink socket, but the sequence number had not yet been registered for routing back to the context that it was sent from. This caused messages to periodically disappear unexpectedly. 2. There was some inconsistency in how Nlmsg::Done packets were handled. This commit standardizes on always returning them from the iteratora. While this may not be preferable from a user standpoint, it will significantly simplify the code, resulting in less room for error in the future.
jbaublitz
force-pushed
the
race-condition
branch
from
5693284
to
cce5855
Compare
|
This indeed resolve #214; thanks! Could you include a regression test to prevent future breakage? |
|
Absolutely. Is the specific operation you were running that triggered the bug sufficient to just add to a unit test or did you want something more involved? |
Should be sufficient, since it was 100% reproducible for me. |
|
I'll try to get to this early next week. |
|
Thank you for fixing this! @jbaublitz could you release a new version containing the fix? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #223
Closes #214