Reclass: 'max' and 'nodata' as valid values #315
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional fix for #67 and #90.
Usage of
max
was already allowed, but with the current implementation, le maximal value itself would always be excluded from the reclassification. I think we can safely assume that if a one usesmax
, the intent is to include it in the reclassification. So I chose to add 0.1 to the maximal value to make sure that the original value would be included in the class. I choose 0.1 instead of 1 thinking that if the input is a Uint8 with a NoData value of 255 and a max value of 254, we don't want to rewrite the NoData cells in the process.I also implemented the
nodata
string as a valid value. It was simply forgotten in the initial fix.