Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JBEAP-20946] Eliminating not existing Java encoding names #6

Merged
merged 1 commit into from
Feb 3, 2021

Conversation

ropalka
Copy link

@ropalka ropalka commented Feb 2, 2021

@ropalka
Copy link
Author

ropalka commented Feb 2, 2021

@scottmarlow please review

@scottmarlow
Copy link

@ropalka I'm guessing that some Java SE implementations might include support for the Java encoding names that we are removing. I'm guessing that Java on an IBM mainframe would need to support the various EBCDIC encoding names since 'EBCDICis typically used on the IBM mainframe (with the exception of running Linux which I think usesASCII` character sets).

Could this bug be fixed without removing Java encoding names that might be included in some Java SE implementations?

@ropalka
Copy link
Author

ropalka commented Feb 3, 2021

@scottmarlow your guess was totally right and thus my initial PR proposal was wrong.
I updated PR as you suggested i.e. without removing Java encoding names from the config file.
Since now on we will register particular Java charset name into internal collections if and only if
configured Java charset name is supported on particular JDK. Please review again Scott.

@scottmarlow
Copy link

Should we create an upstream pull request on https://github.com/apache/xalan-j as well?

@scottmarlow scottmarlow merged commit e0c87ba into jboss:jboss_2_7_1 Feb 3, 2021
@ropalka
Copy link
Author

ropalka commented Feb 4, 2021

Does it make sense @scottmarlow ? I see Xalan is dead project - last code change almost 7 years ago.

@scottmarlow
Copy link

I see two possibilities:

  1. Apache Xalan will not release any new versions or merge any of the (few) pending pull requests.
  2. Or someone will do a new release of Xalan in the future that may include pull requests.

Currently, it does look like #1 is currently true but hard to know if/when #2 might happen.

@ropalka ropalka deleted the JBEAP-20946 branch March 2, 2021 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants