Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support JDK21 images for S2I #82

Open
wants to merge 1 commit into
base: eap81-dev
Choose a base branch
from

Conversation

jmesnil
Copy link
Contributor

@jmesnil jmesnil commented Nov 20, 2024

The default JDK version remains 17 for S2I

@github-actions github-actions bot added documentation Improvements or additions to documentation eap81 labels Nov 20, 2024
@mchoma
Copy link

mchoma commented Nov 27, 2024

Application https://github.com/jboss-eap-up-and-running/eap81-getting-started.git does not exist yet.

@jmesnil
Copy link
Contributor Author

jmesnil commented Nov 27, 2024

Application https://github.com/jboss-eap-up-and-running/eap81-getting-started.git does not exist yet.

That's right, and I won't exist for quite some time as we don't have the artifacts to create a EAP 8.1 Java application.
From the Helm Chart perspective, the URL is set and we will not have to update the chart when we create this example.

@mchoma
Copy link

mchoma commented Nov 27, 2024

All eap helm charts so far had example dir

@jmesnil
Copy link
Contributor Author

jmesnil commented Nov 27, 2024

All eap helm charts so far had example dir

Fixed in c616b0e

@mchoma
Copy link

mchoma commented Nov 28, 2024

Fixed in c616b0e

Can you rebase this PR, please? So everything is here and I can test this PR?

The default JDK version remains 17 for S2I

Signed-off-by: Jeff Mesnil <[email protected]>
@jmesnil
Copy link
Contributor Author

jmesnil commented Nov 28, 2024

I've rebased the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation eap81
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants