Added src/docker/Dockerfile #83

amihaiemil · 2016-04-04T20:53:59Z

PR regarding issue #82 . As explained by @original-brownbear , first step is to add this file, then build and push the image to Dockerhub, and then specify that image in .rultor.yml .

amihaiemil · 2016-04-04T20:55:30Z

@original-brownbear Who has to build the image and push it to dockerhub? I suppose Yegor, since rultor's image is also under his name.

original-brownbear · 2016-04-04T21:23:45Z

@amihaiemil yes @yegor256 needs to setup an automated build for this.

dmarkov · 2016-04-05T09:49:13Z

@amihaiemil Many thanks, I will find someone to review it before we merge

dmarkov · 2016-04-05T09:50:53Z

@mkordas could you please review this pull request

amihaiemil · 2016-04-05T10:01:55Z

@mkordas Yegor has to setup automated build of the image on Dockerhub and then I have to specify the image in .rultor.yml. cc: @yegor256

mkordas · 2016-04-05T22:42:37Z

@amihaiemil I'm on it

mkordas · 2016-04-05T23:01:50Z

src/docker/Dockerfile

+#RUN /bin/bash -l -c "gem update"
+#RUN /bin/bash -l -c "gem install nokogiri"
+#RUN /bin/bash -l -c "gem install bundler"
+#RUN echo 'source /usr/share/rvm/scripts/rvm' >> /etc/bash.bashrc


@amihaiemil If it's commented out, why not delete it?

@mkordas I removed commented block.

mkordas · 2016-04-05T23:04:58Z

@amihaiemil please see inital review. I think we should begin with minimal image instead.

mkordas · 2016-04-06T17:03:57Z

@amihaiemil I'm back

mkordas · 2016-04-06T17:17:12Z

@original-brownbear I need hour advice here - should we clean the things up here or leave as it is? E.g. nodejs is clearly not needed, but @amihaiemil did what he was told to do - just copy the image.

mkordas · 2016-04-06T17:17:44Z

src/docker/Dockerfile

@@ -0,0 +1,97 @@
+# Copyright (c) 2012-2015, jcabi.com


@amihaiemil now we need to upload this image to Docker Hub

@amihaiemil and of course update .rultor.yml to use it

original-brownbear · 2016-04-06T17:24:30Z

@mkordas sure :) Damn looking at that ticket again it's worded in a little unfortunate manner :)

But agreed, simply copying the image was my suggested quick fix, obviously it's not even close to being an optimal solution. In a sense it is my mistake not that of the performer that the description leads to a rather iffy solution now.
Maybe ask the architect here too, but I think it would be "fair" in the sense that the performer only has to resolve the actual stated issue, not an issue refined by the author in hindsight to simply:

Remove the apt-get update && apt-get upgrade stuff because it's really bad
Add a puzzle asking to clean up the image removing unnecessary things from it and locking in all versions 100%.

Makes sense ? :)

amihaiemil · 2016-04-06T18:28:52Z

@mkordas As the author suggested, I removed the apt-get upgrate/update commands and added puzzle for packages version lock. Yegor has to set automated build of the image on Dockerhub, not me. After he is done, I willl specify the image in .rultor.yml.

mkordas · 2016-04-06T22:19:12Z

@amihaiemil I will check it now

mkordas · 2016-04-06T22:22:26Z

src/main/java/com/jcabi/aether/Aether.java

@@ -95,6 +95,9 @@
 *  and verify the expected HTTP requests have been sent to the mocked server.
 * @todo #69:30min Fix NullPointerExceptions in CL build for Open JDK6.
 * @todo #69:30min Fix UnsupportedClassVersionError in CL build for Open JDK6.
+ * @todo #82:30min Clean unnecessary docker setup (src/docler/Dockerfile) and set
+ *  versions to the used packages (e.g. lock java version instead of default
+ *  jdk). Discuss with architect.


@amihaiemil I don't think that much discussion is needed here. I would stress that the goal here is to have minimal docker image with all versions locked that is enough to build this project.

@mkordas I meant discuss the needed versions. Because for sure, the first question will be "OK, but what versions exactly are needed?"

mkordas · 2016-04-06T22:23:44Z

@amihaiemil so we need additional puzzle just for Yegor, right? How we are going to track these tasks?

mkordas · 2016-04-06T22:24:42Z

@amihaiemil please see my comments above

original-brownbear · 2016-04-12T22:04:05Z

@mkordas yes, Yegor needs to do this.

mkordas · 2016-04-12T22:30:16Z

@yegor256 please merge with a button as explained by @original-brownbear above

yegor256 · 2016-04-13T11:42:15Z

@amihaiemil merged

amihaiemil · 2016-04-13T12:41:09Z

@yegor256 Thanks

mkordas · 2016-04-14T06:42:31Z

@original-brownbear @yegor256 maybe let's try to do the deployment with a new image

mkordas · 2016-04-14T06:42:37Z

@rultor deploy

rultor · 2016-04-14T06:43:50Z

@rultor deploy

@mkordas Thanks for your request. @yegor256 Please confirm this.

original-brownbear · 2016-04-14T07:30:09Z

@mkordas yea that should work, otherwise we need to reopen the issue I'm afraid.

dmarkov · 2016-04-14T13:32:15Z

@mkordas Thank you, I have added 52 mins to your account in payment/transaction "570f9b99c1b2190a20000319", time consumed: 194 hours and 57 mins; you're getting extra minutes here (c=37); +52 added to your rating, current score is: +8571

dmarkov · 2016-04-14T13:32:21Z

@rultor deploy now pls

rultor · 2016-04-14T13:32:40Z

@rultor deploy now pls

@dmarkov OK, I'll try to deploy now. You can check the progress here

rultor · 2016-04-14T13:33:16Z

@rultor deploy now pls

@amihaiemil @dmarkov Oops, I failed. You can see the full log here (spent 24s)

+ set -o pipefail
++ dirname ./run.sh
+ cd .
+ echo 359
+ echo '1.61.8 b552866'
1.61.8 b552866
+ date
Thu Apr 14 13:33:07 UTC 2016
+ uptime
 13:33:07 up 13 days, 18:24,  0 users,  load average: 4.58, 5.31, 4.13
+ [email protected]:jcabi/jcabi-aether.git
+ head_branch=master
+ vars=('--env=MAVEN_OPTS=-XX:MaxPermSize=256m -Xmx1g' '[email protected]:jcabi/jcabi-aether.git' '--env=head_branch=master')
+ image=yegor256/jcabi-aether
+ directory=
+ scripts=('sudo gem install --no-ri --no-rdoc pdd' ';' 'sudo gem install --no-ri --no-rdoc est' ';' 'mvn clean deploy -Pqulice --errors --settings ../settings.xml' ';' 'mvn clean' ';' 'pdd --source=$(pwd) --verbose --file=jcabi-aether.xml' ';' 's3cmd --no-progress put jcabi-aether.xml --config=../s3cfg s3://pdd.teamed.io/jcabi-aether.xml' ';' 'est --dir=./est --verbose --file=jcabi-aether.xml --format=xml' ';' 's3cmd --no-progress put jcabi-aether.xml --config=../s3cfg s3://est.teamed.io/jcabi-aether.xml' ';')
+ squash=false
+ ff=default
+ rebase=false
+ container=jcabi_jcabi-aether_83
+ as_root=false
+ mkdir -p /home/rultor/.ssh
+ echo -e 'Host github.com\n\tStrictHostKeyChecking no\n'
+ chmod 600 /home/rultor/.ssh/config
+ git clone [email protected]:jcabi/jcabi-aether.git repo
Cloning into 'repo'...
+ cd repo
+ git config user.email [email protected]
+ git config user.name rultor
+ '[' -z 'sudo gem install --no-ri --no-rdoc pdd' ']'
+ cd ..
+ cat
+ '[' false = true ']'
+ cat
+ chmod a+x entry.sh
+ cat
+ echo 'sudo gem install --no-ri --no-rdoc pdd' ';' 'sudo gem install --no-ri --no-rdoc est' ';' 'mvn clean deploy -Pqulice --errors --settings ../settings.xml' ';' 'mvn clean' ';' 'pdd --source=$(pwd) --verbose --file=jcabi-aether.xml' ';' 's3cmd --no-progress put jcabi-aether.xml --config=../s3cfg s3://pdd.teamed.io/jcabi-aether.xml' ';' 'est --dir=./est --verbose --file=jcabi-aether.xml --format=xml' ';' 's3cmd --no-progress put jcabi-aether.xml --config=../s3cfg s3://est.teamed.io/jcabi-aether.xml' ';'
+ rm -rf .gpg
+ cd repo
+ docker_when_possible
+ true
++ sed 's/ /\n/g'
++ tail -n 1
++ uptime
+ load=4.16
++ bc
++ echo 4.16 '>' 30
+ '[' 0 -eq 1 ']'
+ echo 'load average is 4.16, low enough to run a new Docker container'
load average is 4.16, low enough to run a new Docker container
+ break
+ cd ..
+ '[' -n '' ']'
+ use_image=yegor256/jcabi-aether
+ docker pull yegor256/jcabi-aether
Using default tag: latest
Pulling repository docker.io/yegor256/jcabi-aether
Tag latest not found in repository docker.io/yegor256/jcabi-aether
'cid' file is absent, container wasn't started correctly

amihaiemil · 2016-04-15T17:08:30Z

@original-brownbear Do you happen to know what went wrong? It seems to me some config on Yegor's DockerHub? He needs to define the 'latest' tag?

original-brownbear · 2016-04-15T17:10:43Z

@amihaiemil yes exactly, latest is missing.

amihaiemil · 2016-04-15T17:13:48Z

@yegor256 Can you pls define the latest tag, so the build passes? Issue #78 depends on this since the PR for it cannot be merged. Thanks.

yegor256 · 2016-04-17T17:22:23Z

@amihaiemil it is "defined", as far as I understand:

If you need me to do something else, please give more detailed instructions

original-brownbear · 2016-04-17T17:27:46Z

@yegor256 The build for this thing failed ...

maybe hit the trigger button there and see if it works on retry before the Dockerfile issue gets reopened ... ( maybe we get lucky and it was just a random apt issue, seems it didn't find some package from the Dockerhub logs).

yegor256 · 2016-04-17T17:32:56Z

@original-brownbear triggered it a second ago... let's wait

original-brownbear · 2016-04-17T17:39:24Z

@yegor256 it cannot work ... The Dockerfile contains this :

RUN apt-get update & apt-get install -y \

one & where we need && ... don't think this warrants a ticket really right?, maybe you just push the fix for that?
Here: https://github.com/jcabi/jcabi-aether/blob/master/src/docker/Dockerfile#L44

yegor256 · 2016-04-17T17:44:54Z

@original-brownbear fixed in 5f445b0

original-brownbear · 2016-04-17T17:48:52Z

@yegor256 phew ... you fixed it in a different instance 2 occurrences left still:
https://github.com/jcabi/jcabi-aether/blob/master/src/docker/Dockerfile#L57
https://github.com/jcabi/jcabi-aether/blob/master/src/docker/Dockerfile#L44

how on earth did we all miss that when reviewing this ...

yegor256 · 2016-04-17T17:50:33Z

@original-brownbear fixed in 9b81a37

original-brownbear · 2016-04-17T18:10:12Z

@yegor256 thanks! looks good now, build on Dockerhub worked, I guess we can try deploying again :)

yegor256 · 2016-04-17T18:10:34Z

@original-brownbear cool!

added src/docker/Dockerfile

6ad8841

dmarkov added CR @mkordas labels Apr 5, 2016

dmarkov assigned mkordas Apr 5, 2016

dmarkov added the 15 mins label Apr 5, 2016

mkordas reviewed Apr 5, 2016
View reviewed changes

cleaner Dockerfile

5dc5b35

mkordas reviewed Apr 6, 2016
View reviewed changes

removed apt-get updrage from Dockerfile and added puzzle

7bc558d

mkordas reviewed Apr 6, 2016
View reviewed changes

more detailed todo

bc012d6

yegor256 merged commit 25798b6 into jcabi:master Apr 13, 2016

amihaiemil mentioned this pull request Apr 13, 2016

Rultor Build Fails on Recent Versions of yegor256/rultor #82

Closed

amihaiemil deleted the 82 branch April 13, 2016 17:29

yegor256 pushed a commit that referenced this pull request Apr 17, 2016

#83 typo in Dockerfile

5f445b0

yegor256 pushed a commit that referenced this pull request Apr 17, 2016

#83 more typos in Dockerfile

9b81a37

amihaiemil mentioned this pull request Sep 2, 2016

Cleaned Dockerfile and locker version for openjdk7 #90

Merged

Added src/docker/Dockerfile #83

Added src/docker/Dockerfile #83

Conversation

amihaiemil commented Apr 4, 2016

amihaiemil commented Apr 4, 2016

original-brownbear commented Apr 4, 2016

dmarkov commented Apr 5, 2016

dmarkov commented Apr 5, 2016

amihaiemil commented Apr 5, 2016

mkordas commented Apr 5, 2016

mkordas Apr 5, 2016

Choose a reason for hiding this comment

amihaiemil Apr 6, 2016

Choose a reason for hiding this comment

mkordas commented Apr 5, 2016

mkordas commented Apr 6, 2016

mkordas commented Apr 6, 2016

mkordas Apr 6, 2016

Choose a reason for hiding this comment

mkordas Apr 6, 2016

Choose a reason for hiding this comment

original-brownbear commented Apr 6, 2016

amihaiemil commented Apr 6, 2016

mkordas commented Apr 6, 2016

mkordas Apr 6, 2016

Choose a reason for hiding this comment

amihaiemil Apr 7, 2016

Choose a reason for hiding this comment

mkordas commented Apr 6, 2016

mkordas commented Apr 6, 2016

original-brownbear commented Apr 12, 2016

mkordas commented Apr 12, 2016

yegor256 commented Apr 13, 2016

amihaiemil commented Apr 13, 2016

mkordas commented Apr 14, 2016

mkordas commented Apr 14, 2016

rultor commented Apr 14, 2016

original-brownbear commented Apr 14, 2016

dmarkov commented Apr 14, 2016

dmarkov commented Apr 14, 2016

rultor commented Apr 14, 2016

rultor commented Apr 14, 2016

amihaiemil commented Apr 15, 2016

original-brownbear commented Apr 15, 2016

amihaiemil commented Apr 15, 2016 • edited Loading

yegor256 commented Apr 17, 2016

original-brownbear commented Apr 17, 2016

yegor256 commented Apr 17, 2016

original-brownbear commented Apr 17, 2016 • edited Loading

yegor256 commented Apr 17, 2016

original-brownbear commented Apr 17, 2016 • edited Loading

yegor256 commented Apr 17, 2016

original-brownbear commented Apr 17, 2016 • edited Loading

yegor256 commented Apr 17, 2016

amihaiemil commented Apr 15, 2016 •

edited

Loading

original-brownbear commented Apr 17, 2016 •

edited

Loading

original-brownbear commented Apr 17, 2016 •

edited

Loading

original-brownbear commented Apr 17, 2016 •

edited

Loading