Fix(Simple Build Pipeline): Removes race condition between helix core…

… and helix authentication service (aws-games#338)
jcwolfaws · Oct 4, 2024 · 7738dcd · 7738dcd
1 parent 522e627
commit 7738dcd
Show file tree

Hide file tree

Showing 4 changed files with 39 additions and 37 deletions.
diff --git a/modules/perforce/helix-core/plan b/modules/perforce/helix-core/plan
diff --git a/modules/perforce/helix-core/pln b/modules/perforce/helix-core/pln
diff --git a/samples/simple-build-pipeline/README.md b/samples/simple-build-pipeline/README.md
@@ -4,13 +4,13 @@
 | Name | Version |
 |------|---------|
 | <a name="requirement_terraform"></a> [terraform](#requirement\_terraform) | >= 1.0 |
-| <a name="requirement_aws"></a> [aws](#requirement\_aws) | 5.68.0 |
+| <a name="requirement_aws"></a> [aws](#requirement\_aws) | 5.69.0 |
 
 ## Providers
 
 | Name | Version |
 |------|---------|
-| <a name="provider_aws"></a> [aws](#provider\_aws) | 5.66.0 |
+| <a name="provider_aws"></a> [aws](#provider\_aws) | 5.55.0 |
 
 ## Modules
 
@@ -25,41 +25,41 @@
 
 | Name | Type |
 |------|------|
-| [aws_acm_certificate.helix](https://registry.terraform.io/providers/hashicorp/aws/5.68.0/docs/resources/acm_certificate) | resource |
-| [aws_acm_certificate.jenkins](https://registry.terraform.io/providers/hashicorp/aws/5.68.0/docs/resources/acm_certificate) | resource |
-| [aws_acm_certificate_validation.helix](https://registry.terraform.io/providers/hashicorp/aws/5.68.0/docs/resources/acm_certificate_validation) | resource |
-| [aws_acm_certificate_validation.jenkins](https://registry.terraform.io/providers/hashicorp/aws/5.68.0/docs/resources/acm_certificate_validation) | resource |
-| [aws_default_security_group.default](https://registry.terraform.io/providers/hashicorp/aws/5.68.0/docs/resources/default_security_group) | resource |
-| [aws_ecs_cluster.build_pipeline_cluster](https://registry.terraform.io/providers/hashicorp/aws/5.68.0/docs/resources/ecs_cluster) | resource |
-| [aws_ecs_cluster_capacity_providers.providers](https://registry.terraform.io/providers/hashicorp/aws/5.68.0/docs/resources/ecs_cluster_capacity_providers) | resource |
-| [aws_eip.nat_gateway_eip](https://registry.terraform.io/providers/hashicorp/aws/5.68.0/docs/resources/eip) | resource |
-| [aws_internet_gateway.igw](https://registry.terraform.io/providers/hashicorp/aws/5.68.0/docs/resources/internet_gateway) | resource |
-| [aws_nat_gateway.nat_gateway](https://registry.terraform.io/providers/hashicorp/aws/5.68.0/docs/resources/nat_gateway) | resource |
-| [aws_route53_record.helix_authentication_service](https://registry.terraform.io/providers/hashicorp/aws/5.68.0/docs/resources/route53_record) | resource |
-| [aws_route53_record.helix_cert](https://registry.terraform.io/providers/hashicorp/aws/5.68.0/docs/resources/route53_record) | resource |
-| [aws_route53_record.helix_swarm](https://registry.terraform.io/providers/hashicorp/aws/5.68.0/docs/resources/route53_record) | resource |
-| [aws_route53_record.jenkins](https://registry.terraform.io/providers/hashicorp/aws/5.68.0/docs/resources/route53_record) | resource |
-| [aws_route53_record.jenkins_cert](https://registry.terraform.io/providers/hashicorp/aws/5.68.0/docs/resources/route53_record) | resource |
-| [aws_route53_record.perforce_helix_core](https://registry.terraform.io/providers/hashicorp/aws/5.68.0/docs/resources/route53_record) | resource |
-| [aws_route53_record.perforce_helix_core_pvt](https://registry.terraform.io/providers/hashicorp/aws/5.68.0/docs/resources/route53_record) | resource |
-| [aws_route53_zone.helix_private_zone](https://registry.terraform.io/providers/hashicorp/aws/5.68.0/docs/resources/route53_zone) | resource |
-| [aws_route_table.private_rt](https://registry.terraform.io/providers/hashicorp/aws/5.68.0/docs/resources/route_table) | resource |
-| [aws_route_table.public_rt](https://registry.terraform.io/providers/hashicorp/aws/5.68.0/docs/resources/route_table) | resource |
-| [aws_route_table_association.private_rt_asso](https://registry.terraform.io/providers/hashicorp/aws/5.68.0/docs/resources/route_table_association) | resource |
-| [aws_route_table_association.public_rt_asso](https://registry.terraform.io/providers/hashicorp/aws/5.68.0/docs/resources/route_table_association) | resource |
-| [aws_subnet.private_subnets](https://registry.terraform.io/providers/hashicorp/aws/5.68.0/docs/resources/subnet) | resource |
-| [aws_subnet.public_subnets](https://registry.terraform.io/providers/hashicorp/aws/5.68.0/docs/resources/subnet) | resource |
-| [aws_vpc.build_pipeline_vpc](https://registry.terraform.io/providers/hashicorp/aws/5.68.0/docs/resources/vpc) | resource |
-| [aws_vpc_security_group_ingress_rule.helix_auth_access](https://registry.terraform.io/providers/hashicorp/aws/5.68.0/docs/resources/vpc_security_group_ingress_rule) | resource |
-| [aws_vpc_security_group_ingress_rule.helix_auth_inbound_core](https://registry.terraform.io/providers/hashicorp/aws/5.68.0/docs/resources/vpc_security_group_ingress_rule) | resource |
-| [aws_vpc_security_group_ingress_rule.helix_core_access](https://registry.terraform.io/providers/hashicorp/aws/5.68.0/docs/resources/vpc_security_group_ingress_rule) | resource |
-| [aws_vpc_security_group_ingress_rule.helix_core_inbound_build_farm](https://registry.terraform.io/providers/hashicorp/aws/5.68.0/docs/resources/vpc_security_group_ingress_rule) | resource |
-| [aws_vpc_security_group_ingress_rule.helix_core_inbound_swarm](https://registry.terraform.io/providers/hashicorp/aws/5.68.0/docs/resources/vpc_security_group_ingress_rule) | resource |
-| [aws_vpc_security_group_ingress_rule.helix_swarm_access](https://registry.terraform.io/providers/hashicorp/aws/5.68.0/docs/resources/vpc_security_group_ingress_rule) | resource |
-| [aws_vpc_security_group_ingress_rule.helix_swarm_inbound_core](https://registry.terraform.io/providers/hashicorp/aws/5.68.0/docs/resources/vpc_security_group_ingress_rule) | resource |
-| [aws_vpc_security_group_ingress_rule.jenkins_access](https://registry.terraform.io/providers/hashicorp/aws/5.68.0/docs/resources/vpc_security_group_ingress_rule) | resource |
-| [aws_availability_zones.available](https://registry.terraform.io/providers/hashicorp/aws/5.68.0/docs/data-sources/availability_zones) | data source |
-| [aws_route53_zone.root](https://registry.terraform.io/providers/hashicorp/aws/5.68.0/docs/data-sources/route53_zone) | data source |
+| [aws_acm_certificate.helix](https://registry.terraform.io/providers/hashicorp/aws/5.69.0/docs/resources/acm_certificate) | resource |
+| [aws_acm_certificate.jenkins](https://registry.terraform.io/providers/hashicorp/aws/5.69.0/docs/resources/acm_certificate) | resource |
+| [aws_acm_certificate_validation.helix](https://registry.terraform.io/providers/hashicorp/aws/5.69.0/docs/resources/acm_certificate_validation) | resource |
+| [aws_acm_certificate_validation.jenkins](https://registry.terraform.io/providers/hashicorp/aws/5.69.0/docs/resources/acm_certificate_validation) | resource |
+| [aws_default_security_group.default](https://registry.terraform.io/providers/hashicorp/aws/5.69.0/docs/resources/default_security_group) | resource |
+| [aws_ecs_cluster.build_pipeline_cluster](https://registry.terraform.io/providers/hashicorp/aws/5.69.0/docs/resources/ecs_cluster) | resource |
+| [aws_ecs_cluster_capacity_providers.providers](https://registry.terraform.io/providers/hashicorp/aws/5.69.0/docs/resources/ecs_cluster_capacity_providers) | resource |
+| [aws_eip.nat_gateway_eip](https://registry.terraform.io/providers/hashicorp/aws/5.69.0/docs/resources/eip) | resource |
+| [aws_internet_gateway.igw](https://registry.terraform.io/providers/hashicorp/aws/5.69.0/docs/resources/internet_gateway) | resource |
+| [aws_nat_gateway.nat_gateway](https://registry.terraform.io/providers/hashicorp/aws/5.69.0/docs/resources/nat_gateway) | resource |
+| [aws_route53_record.helix_authentication_service](https://registry.terraform.io/providers/hashicorp/aws/5.69.0/docs/resources/route53_record) | resource |
+| [aws_route53_record.helix_cert](https://registry.terraform.io/providers/hashicorp/aws/5.69.0/docs/resources/route53_record) | resource |
+| [aws_route53_record.helix_swarm](https://registry.terraform.io/providers/hashicorp/aws/5.69.0/docs/resources/route53_record) | resource |
+| [aws_route53_record.jenkins](https://registry.terraform.io/providers/hashicorp/aws/5.69.0/docs/resources/route53_record) | resource |
+| [aws_route53_record.jenkins_cert](https://registry.terraform.io/providers/hashicorp/aws/5.69.0/docs/resources/route53_record) | resource |
+| [aws_route53_record.perforce_helix_core](https://registry.terraform.io/providers/hashicorp/aws/5.69.0/docs/resources/route53_record) | resource |
+| [aws_route53_record.perforce_helix_core_pvt](https://registry.terraform.io/providers/hashicorp/aws/5.69.0/docs/resources/route53_record) | resource |
+| [aws_route53_zone.helix_private_zone](https://registry.terraform.io/providers/hashicorp/aws/5.69.0/docs/resources/route53_zone) | resource |
+| [aws_route_table.private_rt](https://registry.terraform.io/providers/hashicorp/aws/5.69.0/docs/resources/route_table) | resource |
+| [aws_route_table.public_rt](https://registry.terraform.io/providers/hashicorp/aws/5.69.0/docs/resources/route_table) | resource |
+| [aws_route_table_association.private_rt_asso](https://registry.terraform.io/providers/hashicorp/aws/5.69.0/docs/resources/route_table_association) | resource |
+| [aws_route_table_association.public_rt_asso](https://registry.terraform.io/providers/hashicorp/aws/5.69.0/docs/resources/route_table_association) | resource |
+| [aws_subnet.private_subnets](https://registry.terraform.io/providers/hashicorp/aws/5.69.0/docs/resources/subnet) | resource |
+| [aws_subnet.public_subnets](https://registry.terraform.io/providers/hashicorp/aws/5.69.0/docs/resources/subnet) | resource |
+| [aws_vpc.build_pipeline_vpc](https://registry.terraform.io/providers/hashicorp/aws/5.69.0/docs/resources/vpc) | resource |
+| [aws_vpc_security_group_ingress_rule.helix_auth_access](https://registry.terraform.io/providers/hashicorp/aws/5.69.0/docs/resources/vpc_security_group_ingress_rule) | resource |
+| [aws_vpc_security_group_ingress_rule.helix_auth_inbound_core](https://registry.terraform.io/providers/hashicorp/aws/5.69.0/docs/resources/vpc_security_group_ingress_rule) | resource |
+| [aws_vpc_security_group_ingress_rule.helix_core_access](https://registry.terraform.io/providers/hashicorp/aws/5.69.0/docs/resources/vpc_security_group_ingress_rule) | resource |
+| [aws_vpc_security_group_ingress_rule.helix_core_inbound_build_farm](https://registry.terraform.io/providers/hashicorp/aws/5.69.0/docs/resources/vpc_security_group_ingress_rule) | resource |
+| [aws_vpc_security_group_ingress_rule.helix_core_inbound_swarm](https://registry.terraform.io/providers/hashicorp/aws/5.69.0/docs/resources/vpc_security_group_ingress_rule) | resource |
+| [aws_vpc_security_group_ingress_rule.helix_swarm_access](https://registry.terraform.io/providers/hashicorp/aws/5.69.0/docs/resources/vpc_security_group_ingress_rule) | resource |
+| [aws_vpc_security_group_ingress_rule.helix_swarm_inbound_core](https://registry.terraform.io/providers/hashicorp/aws/5.69.0/docs/resources/vpc_security_group_ingress_rule) | resource |
+| [aws_vpc_security_group_ingress_rule.jenkins_access](https://registry.terraform.io/providers/hashicorp/aws/5.69.0/docs/resources/vpc_security_group_ingress_rule) | resource |
+| [aws_availability_zones.available](https://registry.terraform.io/providers/hashicorp/aws/5.69.0/docs/data-sources/availability_zones) | data source |
+| [aws_route53_zone.root](https://registry.terraform.io/providers/hashicorp/aws/5.69.0/docs/data-sources/route53_zone) | data source |
 
 ## Inputs
 

diff --git a/samples/simple-build-pipeline/main.tf b/samples/simple-build-pipeline/main.tf
@@ -43,6 +43,8 @@ module "perforce_helix_core" {
   fully_qualified_domain_name = "core.helix.perforce.${var.root_domain_name}"
 
   helix_authentication_service_url = "https://${aws_route53_record.helix_authentication_service.name}"
+
+  depends_on = [module.perforce_helix_authentication_service]
 }
 
 ##########################################