Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build fixes #79

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Build fixes #79

wants to merge 4 commits into from

Conversation

ScoreUnder
Copy link

@ScoreUnder ScoreUnder commented Feb 9, 2022

  1. Updated CGLM which seems to fix a lot of people's issues with mismatched vector types
  2. Gave make a clearer chain of dependencies and the files we expect from them re. library compilation
  3. Moved the game target up to default position and removed all
  4. Gave the game an order-only dependency on the bin directory (meaning it doesn't get rebuilt every time if that isn't necessary)
  5. Used the compiler's dependency tracking (-MMD, supported by at least gcc and clang) to allow incremental compilation

It's not perfect (I haven't properly inspected the dependencies of the libraries and triggered recompilations of those where necessary) but it should be enough to enable parallel builds and somewhat reliable incremental compilation.

@gngenius02
Copy link

gngenius02 commented Jun 28, 2022

Thanks! I got it running with your help. I tried multiple different variations of below but it was the only way I got it working.

My steps to get the game compiled was as follows:

  1. git clone --recurse-submodules [email protected]:jdah/minecraft-weekend.git
  2. cd minecract-weekend
  3. make (original Makefile)
  4. make game (original Makefile)
  5. cd lib/cglm and delete all files/folders.
  6. git clone [email protected]:recp/cglm.git .
  7. cd ../.. (should be back in minecraft-weekend folder)
  8. copy your changes to Makefile.
  9. run make.

Copy link

@techguy16 techguy16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These fixes fix a lot of bugs - Thank You.
I hope @jdah merges this branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants