Compatibility with .NET Standard 2.0 #130
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release 1.15.3
Fix minor error
Add support for value of type JTokenType.Date
…et. Some of the tests around sections not working yet either.
Corrects paths for spec to be from the root
Add dictionary converter for json spec
|
.NET Standard requires spaces instead of tabs? |
|
When this PR will be merged, because we hawing compilation errors on .netCore 5.0? |
|
Hi there, Nustache will not be being updated to netstandard 2.0. Instead we're recommending people migrate to Stubble the successor to nustache that has all the same functionality and is faster and more extendable. Please let us know if you have any issues migrating by opening an issue in the Stubble repository. It should hopefully be painless and a simple drop-in provided you've not using custom extensions to Nustache. |
|
@Romanx Thanks for information! :) We successfully migrated our implementation to Stubble :) 🥇 |
|
@eimantaszlabys that's great to hear. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all - as discussed with @Romanx this is the initial set of changes required to make Nustache compatible with .NET Standard.
Although I'm pretty familiar with the process of porting stuff to .NET Standard, I'm only passingly-familiar with Nustache itself (this work primarily driven by dotnet/docfx#1963) so I'd appreciate a sanity check 😁