table: ignore non-printable characters when suppressing empty columns #327
Conversation
This change ensures that non-printable characters (e.g., text direction markers) are ignored when determining whether to suppress empty columns. This is required to use FormatOptions.Direction in conjunction with SuppressEmptyColumns().
|
Pull Request Test Coverage Report for Build 10482223208Details
💛 - Coveralls |
|
Thanks for your contribution. Will cut a release later this week with this change incorporated. |
| // the text.Direction modifiers. These should not be considered | ||
| // when deciding to suppress a column. | ||
| for _, r := range row[colIdx] { | ||
| if unicode.IsPrint(r) { |
There was a problem hiding this comment.
I considered only ignoring the specific characters used by text.LeftToRight (\u202a) and text.RightToLeft (\u202b). However, this approach would require the check to be updated if any new modifiers were added later, which could easily be overlooked.
I figure it’s unlikely someone would want to print a column containing only non-printable characters. More likely, this will confuse people—just as it did me when my seemingly empty columns weren't being suppressed. 😅
There was a problem hiding this comment.
No I like the final approach much better than checking for a couple of characters that we know of today.
Proposed Changes
This change ensures that non-printable characters (e.g., text direction markers) are ignored when determining whether to suppress empty columns. This is required to use FormatOptions.Direction in conjunction with SuppressEmptyColumns().