Merge pull request wordpress-mobile#21054 from wordpress-mobile/reduc…

…e-setup-time [UI Tests] - Removing unnecessary flows to speed up tests
jeff4a501 · Jul 12, 2023 · 9be6a75 · 9be6a75
2 parents 79071b9 + ddec037
commit 9be6a75
Show file tree

Hide file tree

Showing 5 changed files with 20 additions and 20 deletions.
diff --git a/WordPress/UITests/Tests/MainNavigationTests.swift b/WordPress/UITests/Tests/MainNavigationTests.swift
@@ -10,8 +10,6 @@ class MainNavigationTests: XCTestCase {
             email: WPUITestCredentials.testWPcomUserEmail,
             password: WPUITestCredentials.testWPcomPassword
         )
-        try TabNavComponent()
-            .goToMySiteScreen()
             .goToMenu()
     }
 

diff --git a/WordPress/UITests/Tests/ReaderTests.swift b/WordPress/UITests/Tests/ReaderTests.swift
@@ -10,9 +10,8 @@ class ReaderTests: XCTestCase {
             email: WPUITestCredentials.testWPcomUserEmail,
             password: WPUITestCredentials.testWPcomPassword
         )
-        try EditorFlow
-            .goToMySiteScreen()
-            .tabBar.goToReaderScreen()
+        try TabNavComponent()
+            .goToReaderScreen()
     }
 
     override func tearDownWithError() throws {

diff --git a/WordPress/UITests/Tests/StatsTests.swift b/WordPress/UITests/Tests/StatsTests.swift
@@ -9,7 +9,6 @@ class StatsTests: XCTestCase {
             email: WPUITestCredentials.testWPcomUserEmail,
             password: WPUITestCredentials.testWPcomPassword
         )
-        try MySiteScreen()
             .goToMenu()
             .goToStatsScreen()
             .switchTo(mode: .insights)

diff --git a/WordPress/UITestsFoundation/Screens/Login/LoginEpilogueScreen.swift b/WordPress/UITestsFoundation/Screens/Login/LoginEpilogueScreen.swift
@@ -65,29 +65,35 @@ public class LoginEpilogueScreen: ScreenObject {
     }
 
     private func dismissQuickStartPromptIfNeeded() throws {
-        try XCTContext.runActivity(named: "Dismiss quick start prompt if needed.") { _ in
-            guard QuickStartPromptScreen.isLoaded() else { return }
-
+        XCTContext.runActivity(named: "Dismiss quick start prompt if needed.") { _ in
             Logger.log(message: "Dismising quick start prompt...", event: .i)
-            _ = try QuickStartPromptScreen().selectNoThanks()
+            do {
+                _ = try QuickStartPromptScreen().selectNoThanks()
+            } catch {
+                return
+            }
         }
     }
 
     private func dismissOnboardingQuestionsPromptIfNeeded() throws {
-        try XCTContext.runActivity(named: "Dismiss onboarding questions prompt if needed.") { _ in
-            guard OnboardingQuestionsPromptScreen.isLoaded() else { return }
-
+        XCTContext.runActivity(named: "Dismiss onboarding questions prompt if needed.") { _ in
             Logger.log(message: "Dismissing onboarding questions prompt...", event: .i)
-            _ = try OnboardingQuestionsPromptScreen().selectSkip()
+            do {
+                _ = try OnboardingQuestionsPromptScreen().selectSkip()
+            } catch {
+                return
+            }
         }
     }
 
     private func dismissFeatureIntroductionIfNeeded() throws {
-        try XCTContext.runActivity(named: "Dismiss feature introduction screen if needed.") { _ in
-            guard FeatureIntroductionScreen.isLoaded() else { return }
-
+        XCTContext.runActivity(named: "Dismiss feature introduction screen if needed.") { _ in
             Logger.log(message: "Dismissing feature introduction screen...", event: .i)
-            _ = try FeatureIntroductionScreen().dismiss()
+            do {
+                _ = try FeatureIntroductionScreen().dismiss()
+            } catch {
+                return
+            }
         }
     }
 }
diff --git a/WordPress/UITestsFoundation/Screens/Login/Unified/PasswordScreen.swift b/WordPress/UITestsFoundation/Screens/Login/Unified/PasswordScreen.swift
@@ -29,8 +29,6 @@ public class PasswordScreen: ScreenObject {
     public func proceedWithValidPassword() throws -> LoginEpilogueScreen {
         try tryProceed(password: "pw")
 
-        app.dismissSavePasswordPrompt()
-
         return try LoginEpilogueScreen()
     }