Skip to content

Commit

Permalink
Merge pull request wordpress-mobile#20793 from wordpress-mobile/updat…
Browse files Browse the repository at this point in the history
…e-annotate-test-failure-plugin

Send Slack notification for UI/Unit test failures
  • Loading branch information
jostnes authored Jun 2, 2023
2 parents 0239073 + 62594e4 commit d043fbf
Show file tree
Hide file tree
Showing 5 changed files with 15 additions and 17 deletions.
2 changes: 1 addition & 1 deletion .buildkite/cache-builder.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
common_params:
# Common plugin settings to use with the `plugins` key.
- &common_plugins
- automattic/a8c-ci-toolkit#2.15.1
- automattic/a8c-ci-toolkit#2.17.0
- automattic/git-s3-cache#1.1.4:
bucket: "a8c-repo-mirrors"
repo: "automattic/wordpress-ios/"
Expand Down
7 changes: 6 additions & 1 deletion .buildkite/commands/run-ui-tests.sh
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,11 @@ else
echo "The UI Tests, ran during the '🔬 Testing' step above, have failed."
echo "For more details about the failed tests, check the Buildkite annotation, the logs under the '🔬 Testing' section and the \`.xcresult\` and test reports in Buildkite artifacts."
fi
annotate_test_failures "build/results/JetpackUITests.xml"

if [[ $BUILDKITE_BRANCH == trunk ]] || [[ $BUILDKITE_BRANCH == release/* ]]; then
annotate_test_failures "build/results/JetpackUITests.xml" --slack "build-and-ship"
else
annotate_test_failures "build/results/JetpackUITests.xml"
fi

exit $TESTS_EXIT_STATUS
7 changes: 6 additions & 1 deletion .buildkite/commands/run-unit-tests.sh
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,11 @@ else
echo "The Unit Tests, ran during the '🔬 Testing' step above, have failed."
echo "For more details about the failed tests, check the Buildkite annotation, the logs under the '🔬 Testing' section and the \`.xcresult\` and test reports in Buildkite artifacts."
fi
annotate_test_failures "build/results/WordPress.xml"

if [[ $BUILDKITE_BRANCH == trunk ]] || [[ $BUILDKITE_BRANCH == release/* ]]; then
annotate_test_failures "build/results/WordPress.xml" --slack "build-and-ship"
else
annotate_test_failures "build/results/WordPress.xml"
fi

exit $TESTS_EXIT_STATUS
14 changes: 1 addition & 13 deletions .buildkite/pipeline.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
common_params:
# Common plugin settings to use with the `plugins` key.
- &common_plugins
- automattic/a8c-ci-toolkit#2.15.1
- automattic/a8c-ci-toolkit#2.17.0
- automattic/git-s3-cache#1.1.4:
bucket: "a8c-repo-mirrors"
repo: "automattic/wordpress-ios/"
Expand Down Expand Up @@ -73,10 +73,6 @@ steps:
notify:
- github_commit_status:
context: "Unit Tests"
- slack:
channels:
- "#mobile-apps-tests-notif"
if: build.state == "failed" && build.branch == "trunk"

#################
# UI Tests
Expand All @@ -94,10 +90,6 @@ steps:
notify:
- github_commit_status:
context: "UI Tests (iPhone)"
- slack:
channels:
- "#mobile-apps-tests-notif"
if: build.state == "failed" && build.branch == "trunk"

- label: "🔬 :jetpack: UI Tests (iPad)"
command: .buildkite/commands/run-ui-tests.sh 'iPad Air (5th generation)'
Expand All @@ -110,10 +102,6 @@ steps:
notify:
- github_commit_status:
context: "UI Tests (iPad)"
- slack:
channels:
- "#mobile-apps-tests-notif"
if: build.state == "failed" && build.branch == "trunk"

#################
# Linters
Expand Down
2 changes: 1 addition & 1 deletion .buildkite/release-builds.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
common_params:
# Common plugin settings to use with the `plugins` key.
- &common_plugins
- automattic/a8c-ci-toolkit#2.15.1
- automattic/a8c-ci-toolkit#2.17.0
- automattic/git-s3-cache#1.1.4:
bucket: "a8c-repo-mirrors"
repo: "automattic/wordpress-ios/"
Expand Down

0 comments on commit d043fbf

Please sign in to comment.