feat: replace Pest by PHPUnit #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The minimum current stable version of Nextcloud Server is 27 and the minimum PHP version supported by this version is 8.0
For now, LibreSign provide support to all stable releases of Nextcloud Server because LibreSign is a Nextcloud app to do digital signatures.
The current version of this repository use Pest as test suite. The version of Pest compati\ble with PHP8.0 is very old and to be more agnostic of Laravel libraries, I made this migration from Pest to PHPUnit.
This is a PR only as test purpose and to store my progress using your package, isn't necessary to merge.
I also moved the developer dependencies to use
bamarni/composer-bin-pluginpackage and don't impact the code of project with developer dependencies.At time, for now don't will be possible implement at LibreSign because I need to use forms to put visible signature and this package don't have support to this feature. Congratulations by this work!