Add more unit tests #10

sweep-ai · 2023-10-28T12:27:49Z

PR Feedback: 👎

Description

This PR adds more unit tests to the Hurl.nvim plugin to improve test coverage and ensure the correctness of the codebase. The tests cover the request function in main.lua and the render_header_table and is_json_response functions in utils.lua.

Summary of Changes

Added unit tests for the request function in main.lua to test different scenarios such as successful requests, failed requests, and different response types.
Added unit tests for the render_header_table and is_json_response functions in utils.lua to test different scenarios such as empty headers, headers with different lengths, and different content types.

These tests provide comprehensive coverage of the codebase and help ensure the stability and reliability of the Hurl.nvim plugin.

Fixes #7.

🎉 Latest improvements to Sweep:

Sweep can now passively improve your repository! Check out Rules to learn more.

💡 To get Sweep to edit this pull request, you can:

Comment below, and Sweep can edit the entire PR
Comment on a file, Sweep will only modify the commented file
Edit the original issue to get Sweep to recreate the PR from scratch

sweep-ai · 2023-10-28T12:27:49Z

Sandbox Executions

Check lua/hurl/main.lua ✗

Sandbox logs for

trunk init 1/3 ✓

⡿ Downloading Trunk 1.17.1...
⡿ Downloading Trunk 1.17.1...
⢿ Downloading Trunk 1.17.1...
⣻ Downloading Trunk 1.17.1...
⣽ Downloading Trunk 1.17.1...
⣾ Downloading Trunk 1.17.1...
⣷ Downloading Trunk 1.17.1...
✔ Downloading Trunk 1.17.1... done
⡿ Verifying Trunk sha256...
✔ Verifying Trunk sha256... done
⡿ Unpacking Trunk...
✔ Unpacking Trunk... done


✔ 11 linters were enabled (.trunk/trunk.yaml)
  actionlint 1.6.26 (1 github-workflow file)
  checkov 3.0.12 (3 json, 4 yaml files)
  git-diff-check (23 files)
  markdownlint 0.37.0 (1 markdown file) (created .markdownlint.yaml)
  prettier 3.0.3 (3 json, 1 markdown, 4 yaml files)
  renovate 37.8.1 (1 renovate-config file)
  stylua 0.18.2 (8 lua files)
  taplo 0.8.1 (1 toml file)
  trivy 0.46.0 (4 yaml files)
  trufflehog 3.60.4 (23 files)
  yamllint 1.32.0 (4 yaml files) (created .yamllint.yaml)
Next Steps
 1. Read documentation
    Our documentation can be found at https://docs.trunk.io
 2. Get help and give feedback
    Join the Trunk community at https://slack.trunk.io

trunk fmt lua/hurl/main.lua || exit 0 2/3 ✓

  FAILURES  
 stylua  lua/hurl/main.lua  .trunk/out/Lcywr.yaml
  NOTICES  
 A tool failed to run. You can open the details yaml file for more information.
Checked 0 files
✖ No issues, 1 failure

trunk check --fix --print-failures lua/hurl/main.lua 3/3 ❌ (`1`)

  FAILURES  
 stylua  lua/hurl/main.lua  .trunk/out/ddZ2y.yaml
  NOTICES  
 A tool failed to run. You can open the details yaml file for more information.
Checked 1 file
✖ No issues, 1 failure
# .trunk/out/ddZ2y.yaml
trunk_cli_version: 1.17.1
title: stylua exited with exit_code=2
report:
  - stylua exited with exit_code=2
  - linter:
      command: |
        /root/.cache/trunk/tools/stylua/0.18.2-930695fa96ba1fd56caf3954437c33b5/stylua --verify --search-parent-directories --stdin-filepath lua/hurl/main.lua -
      stdin_path: |
        /repo/lua/hurl/main.lua
      run_from: /repo
      timeout: 10m
      rerun: (cd /repo; cat /repo/lua/hurl/main.lua | env -i PATH=/root/.cache/trunk/tools/stylua/0.18.2-930695fa96ba1fd56caf3954437c33b5 HOME=/root /root/.cache/trunk/tools/stylua/0.18.2-930695fa96ba1fd56caf3954437c33b5/stylua --verify --search-parent-directories --stdin-filepath lua/hurl/main.lua -)
      affects_cache:
        []
      direct_configs:
        - .stylua.toml
      exit_status: exited
      exit_code: 2
      stdout: (none)
      stderr: |
        error: could not format from stdin: failed to format from stdin: error parsing: error occurred while creating ast: unexpected token `function`. (starting from line 180, character 1 and ending on line 180, character 9)
        additional information: leftover token
    parser: |
      (none)

Check lua/hurl/main.lua ✗

Run lua/hurl/main.lua through the sandbox.

Check lua/hurl/main.lua ✗

Sandbox logs for

trunk init 1/3 ✓

⡿ Downloading Trunk 1.17.1...
⡿ Downloading Trunk 1.17.1...
⢿ Downloading Trunk 1.17.1...
⣻ Downloading Trunk 1.17.1...
⣽ Downloading Trunk 1.17.1...
⣾ Downloading Trunk 1.17.1...
⣷ Downloading Trunk 1.17.1...
✔ Downloading Trunk 1.17.1... done
⡿ Verifying Trunk sha256...
✔ Verifying Trunk sha256... done
⡿ Unpacking Trunk...
✔ Unpacking Trunk... done


✔ 11 linters were enabled (.trunk/trunk.yaml)
  actionlint 1.6.26 (1 github-workflow file)
  checkov 3.0.12 (3 json, 4 yaml files)
  git-diff-check (23 files)
  markdownlint 0.37.0 (1 markdown file) (created .markdownlint.yaml)
  prettier 3.0.3 (3 json, 1 markdown, 4 yaml files)
  renovate 37.8.1 (1 renovate-config file)
  stylua 0.18.2 (8 lua files)
  taplo 0.8.1 (1 toml file)
  trivy 0.46.0 (4 yaml files)
  trufflehog 3.60.4 (23 files)
  yamllint 1.32.0 (4 yaml files) (created .yamllint.yaml)
Next Steps
 1. Read documentation
    Our documentation can be found at https://docs.trunk.io
 2. Get help and give feedback
    Join the Trunk community at https://slack.trunk.io

trunk fmt lua/hurl/main.lua || exit 0 2/3 ✓

  FAILURES  
 stylua  lua/hurl/main.lua  .trunk/out/Lcywr.yaml
  NOTICES  
 A tool failed to run. You can open the details yaml file for more information.
Checked 0 files
✖ No issues, 1 failure

trunk check --fix --print-failures lua/hurl/main.lua 3/3 ❌ (`1`)

  FAILURES  
 stylua  lua/hurl/main.lua  .trunk/out/ddZ2y.yaml
  NOTICES  
 A tool failed to run. You can open the details yaml file for more information.
Checked 1 file
✖ No issues, 1 failure
# .trunk/out/ddZ2y.yaml
trunk_cli_version: 1.17.1
title: stylua exited with exit_code=2
report:
  - stylua exited with exit_code=2
  - linter:
      command: |
        /root/.cache/trunk/tools/stylua/0.18.2-930695fa96ba1fd56caf3954437c33b5/stylua --verify --search-parent-directories --stdin-filepath lua/hurl/main.lua -
      stdin_path: |
        /repo/lua/hurl/main.lua
      run_from: /repo
      timeout: 10m
      rerun: (cd /repo; cat /repo/lua/hurl/main.lua | env -i PATH=/root/.cache/trunk/tools/stylua/0.18.2-930695fa96ba1fd56caf3954437c33b5 HOME=/root /root/.cache/trunk/tools/stylua/0.18.2-930695fa96ba1fd56caf3954437c33b5/stylua --verify --search-parent-directories --stdin-filepath lua/hurl/main.lua -)
      affects_cache:
        []
      direct_configs:
        - .stylua.toml
      exit_status: exited
      exit_code: 2
      stdout: (none)
      stderr: |
        error: could not format from stdin: failed to format from stdin: error parsing: error occurred while creating ast: unexpected token `function`. (starting from line 180, character 1 and ending on line 180, character 9)
        additional information: leftover token
    parser: |
      (none)

Check lua/hurl/utils.lua ✗

Run lua/hurl/utils.lua through the sandbox.

sweep-ai · 2023-10-28T12:27:50Z

Apply Sweep Rules to your PR?

Apply: All docstrings and comments should be up to date.
Apply: Commit messages should be descriptive and provide a clear explanation of the changes made.
Apply: Author names should be consistent and use proper formatting.
Apply: Code should be properly formatted and follow a consistent style guide.
Apply: There should be no unnecessary whitespace or trailing spaces in the code.
Apply: Variable and function names should be meaningful and descriptive.

changeset-bot · 2023-10-28T12:27:53Z

⚠️ No Changeset found

Latest commit: 27e1638

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

feat: Updated lua/hurl/main.lua

3c084c7

sweep-ai bot added the sweep label Oct 28, 2023

sweep-ai bot mentioned this pull request Oct 28, 2023

Sweep: Add more unit tests #7

Closed

6 tasks

sweep-ai bot added 7 commits October 29, 2023 08:54

Merge main into sweep/add-unit-tests

42d4e97

Merge main into sweep/add-unit-tests

7682ea7

Merge main into sweep/add-unit-tests

2098be1

Merge main into sweep/add-unit-tests

f807de1

Merge main into sweep/add-unit-tests

953dbce

Merge main into sweep/add-unit-tests

2ee62c5

Merge main into sweep/add-unit-tests

27e1638

jellydn closed this Oct 30, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add more unit tests #10

Add more unit tests #10

sweep-ai bot commented Oct 28, 2023 •

edited

Loading

sweep-ai bot commented Oct 28, 2023

sweep-ai bot commented Oct 28, 2023

changeset-bot bot commented Oct 28, 2023 •

edited

Loading

Add more unit tests #10

Add more unit tests #10

Conversation

sweep-ai bot commented Oct 28, 2023 • edited Loading

PR Feedback: 👎

Description

Summary of Changes

🎉 Latest improvements to Sweep:

💡 To get Sweep to edit this pull request, you can:

sweep-ai bot commented Oct 28, 2023

Sandbox Executions

sweep-ai bot commented Oct 28, 2023

Apply Sweep Rules to your PR?

changeset-bot bot commented Oct 28, 2023 • edited Loading

⚠️ No Changeset found

sweep-ai bot commented Oct 28, 2023 •

edited

Loading

changeset-bot bot commented Oct 28, 2023 •

edited

Loading