Fix find entry via treesitter #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* upstream/main: chore(doc): auto generate docs
Lua index starts on 1 so we were accidentally returing the line range of the current node plus one line of the next node.
|
Apply Sweep Rules to your PR?
This is an automated message generated by Sweep AI. |
for more information, see https://pre-commit.ci
7 tasks
|
Thanks @hsanson 🙏 Let me try. |
jellydn
added a commit
that referenced
this pull request
Mar 14, 2024
* Fix HurlRunnterToEntry using treesitter (#116) * chore(doc): auto generate docs * chore(test): add API tests for dog breeds * Fix find entry via treesitter (#124) * Fix HurlRunnterToEntry using treesitter * chore(doc): auto generate docs * Fix find entry method returing two nodes range. Lua index starts on 1 so we were accidentally returing the line range of the current node plus one line of the next node. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * refactor(http_utils): make find_hurl_entry_positions_in_buffer a module function --------- Co-authored-by: Horacio Sanson <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
Fix issue where the find entries method was returning two nodes instead of one.
WHY
HOW
Screenshots (if appropriate):
Types of changes
Checklist: