Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sweep Rules] Improve function name in main.lua #128

Closed
wants to merge 2 commits into from

Conversation

sweep-ai[bot]
Copy link
Contributor

@sweep-ai sweep-ai bot commented Mar 14, 2024

PR Feedback (click)

  • 👍 Sweep Did Well
  • 👎 Sweep Needs Improvement

I created this PR to address this rule:

"Variable and function names should be meaningful and descriptive."

Description

This PR improves the function name in the main.lua file of the hurl.nvim plugin. The function find_hurl_entry_positions_in_buffer has been renamed to find_closest_hurl_entry_position to provide a more descriptive and meaningful name.

Summary of Changes

  • Renamed the function find_hurl_entry_positions_in_buffer to find_closest_hurl_entry_position in the main.lua file.

Please review and merge this PR. Thank you!

Copy link
Contributor Author

sweep-ai bot commented Mar 14, 2024

Rollback Files For Sweep

  • Rollback changes to lua/hurl/main.lua
  • Rollback changes to lua/hurl/main.lua

@sweep-ai sweep-ai bot added the sweep label Mar 14, 2024
Copy link

changeset-bot bot commented Mar 14, 2024

⚠️ No Changeset found

Latest commit: a535402

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jellydn jellydn closed this Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant