Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sweep Rules] Rename variables and functions in lua/hurl/main.lua #17

Closed
wants to merge 3 commits into from

Conversation

sweep-ai[bot]
Copy link
Contributor

@sweep-ai sweep-ai bot commented Oct 31, 2023

PR Feedback: 👎

I created this PR to address this rule:

"Variable and function names should be meaningful and descriptive."

Description

This PR renames variables and functions in lua/hurl/main.lua to make them more meaningful and descriptive. The changes improve the readability and maintainability of the code.

Summary of Changes

  • Renamed the function get_env_file_in_folders() to findEnvFilesInFolders() to accurately reflect its purpose.
  • Renamed the function request() to executeHttpRequest() to accurately reflect its purpose.
  • Renamed the function M.setup() to initializeHurlPlugin() to accurately reflect its purpose.

Copy link
Contributor Author

sweep-ai bot commented Oct 31, 2023

Rollback Files For Sweep

  • Rollback changes to lua/hurl/main.lua
  • Rollback changes to lua/hurl/main.lua

@sweep-ai sweep-ai bot added the sweep label Oct 31, 2023
Copy link
Contributor Author

sweep-ai bot commented Oct 31, 2023

Sandbox Executions

  • Check lua/hurl/main.lua
Sandbox logs for
trunk fmt lua/hurl/main.lua || exit 0 1/2 ✓
Checked 1 file
✔ No issues
trunk check --fix --print-failures lua/hurl/main.lua 2/2 ✓
Checked 1 file
✔ No issues

Copy link

changeset-bot bot commented Oct 31, 2023

⚠️ No Changeset found

Latest commit: 8c0bdac

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jellydn jellydn closed this Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant