Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save private users credentials and fix registry migration logic #1386

Merged
merged 8 commits into from
Oct 27, 2023

Conversation

cewert
Copy link
Member

@cewert cewert commented Sep 21, 2023

Add support for saving credentials for private users. Shows the private saved users with the public users on the same view. Ensure userid's are unique so there's no duplicates.

Fix migration logic. I was only updating the logged in user settings previously. This updates all users found in the registry

Changes

  • Save private users credentials when asked
    • Show the user select screen if there are public users or saved users for the selected server
    • Make sure all userIds are unique - prevent duplicates when there is a public user with saved credentials
  • Fix registry migration logic
    • Update all user settings and not just the logged in user
  • Only save active server url to registry when the connection is successful
  • Remove deprecated "port" setting

@cewert cewert requested a review from a team as a code owner September 21, 2023 18:53
@cewert cewert changed the title Fix registry migration logic Save private users credentials and fix registry migration logic Sep 23, 2023
source/api/userauth.brs Outdated Show resolved Hide resolved
source/migrations.bs Outdated Show resolved Hide resolved
source/utils/config.brs Outdated Show resolved Hide resolved
source/utils/config.brs Outdated Show resolved Hide resolved
@cewert cewert requested a review from 1hitsong October 20, 2023 02:14
@jellyfin-bot jellyfin-bot added the merge-conflict This PR has a merge conflict label Oct 25, 2023
@jellyfin-bot
Copy link
Contributor

This pull request has merge conflicts. Please resolve the conflicts so the PR can be reviewed. Thanks!

@jellyfin-bot jellyfin-bot removed the merge-conflict This PR has a merge conflict label Oct 25, 2023
@cewert cewert merged commit 97575c3 into jellyfin:unstable Oct 27, 2023
9 checks passed
@cewert cewert deleted the loginflow branch October 27, 2023 12:26
@cewert cewert added the feature A new feature that currently doesn't exist. label Nov 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new feature that currently doesn't exist.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants