Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix direct play of the AV1 codec #1393

Merged
merged 9 commits into from
Oct 16, 2023
Merged

Conversation

cewert
Copy link
Member

@cewert cewert commented Sep 27, 2023

CanDecodeVideo() always spits out false when checking the av1 codec with a container but will correctly report support with no container included. This removes the container when checking for support and adds the av1 codec to all containers direct play profile if av1 is supported.

Changes

  • Fix AV1 direct play
  • Fix AV1 profile/level detection
  • Remove user setting for av1 playback since device detection is working now

Issues

Fixes #1392

@cewert cewert requested a review from a team as a code owner September 27, 2023 01:38
Copy link
Member

@1hitsong 1hitsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality looks good. 1 housekeeping item.

settings/settings.json Show resolved Hide resolved
@cewert cewert requested a review from 1hitsong October 16, 2023 02:07
@cewert cewert merged commit e0e9cf6 into jellyfin:unstable Oct 16, 2023
9 checks passed
@cewert cewert deleted the fix-av1-support branch October 16, 2023 17:37
@cewert cewert added the bug-fix This fixes a bug. label Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix This fixes a bug.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

AV1 Doesn't Direct Play (Transcoding Occurs) on Compatible Roku Models with AV1 Enabled in Settings.
2 participants