Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

restore loading spinner to videos #1495

Closed
wants to merge 1 commit into from
Closed

restore loading spinner to videos #1495

wants to merge 1 commit into from

Conversation

sevenrats
Copy link
Member

we lost the first spinner when we moved to universal queue (the one that shows while we wait for the initial request to return) this PR restores it.

@sevenrats sevenrats requested a review from a team as a code owner November 12, 2023 06:54
cewert
cewert requested changes Nov 12, 2023
View reviewed changes
Copy link
Member

@cewert cewert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs more testing with quickplay. You end up with two spinners loading on top of each other and doesn't look good.

@cewert cewert added the general-improvement Quality of life improvements that don't add new functionality. label Nov 12, 2023
@sevenrats
Copy link
Member Author

@cewert good catch. working on it now.

@sevenrats sevenrats closed this Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cewert cewert cewert requested changes

@jimdogx jimdogx jimdogx approved these changes

Assignees
No one assigned
Labels
general-improvement Quality of life improvements that don't add new functionality.
Projects
Ongoing development
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sevenrats @cewert @jimdogx