Use type=module in package.json
#1535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to allow for import statements in future scripts
|
Hi @arturocuya thanks for the PR! 👋 I know you were talking about setting up RTA before, does RTA need these changes or whats the motivation behind the changes? |
Yes, these changes will make my life easier when implementing UI tests with |
cewert
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
"type": "module"to thepackage.jsonfile to facilitate the use ofimportstatements in future scriptsscripts/ropm-hook.jstoscripts/ropm-hook.cjsto keep usingrequireimports for that file only. Also updated theropmnpm script inpackage.jsonto reflect the file name change.