Set video MaxVideoDecodeResolution to TV resolution #1557
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cewert
force-pushed
the
fix-video-memory-crash
branch
from
e2d5243 to
d4e53f9
Compare
|
This pull request has been inactive for 21 days and will be automatically closed in 7 days if there is no further activity. |
|
@cewert In our testing we found this didn't fix the issue. Is this still a viable PR, or can it be closed? |
|
I wasn't able to test but you guys said this PR didn't help with the error. I don't see how merging this could hurt anything but yea we should probably just close it and wait to mess with this setting until a crash or something forces us to. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sets
MaxVideoDecodeResolutionon the video node to the attached devices resolution to try and prevent memory errors when playing certain files. The default is unlimited and that's what we were using before.Changes
Issues
Fixes #1554