- added nullpointer checks

- consolidation of usage @nonnull vs. @nonnull
jenkinsci · Dec 2, 2024 · 382f093 · 382f093
1 parent 83eba49
commit 382f093
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 2 deletions.
diff --git a/src/main/java/org/jenkinsci/plugins/JiraTestResultReporter/JiraTestDataPublisher.java b/src/main/java/org/jenkinsci/plugins/JiraTestResultReporter/JiraTestDataPublisher.java
@@ -36,6 +36,7 @@
 import com.atlassian.jira.rest.client.internal.async.AsynchronousHttpClientFactory;
 import com.atlassian.jira.rest.client.internal.async.AsynchronousJiraRestClientFactory;
 import edu.umd.cs.findbugs.annotations.CheckForNull;
+import edu.umd.cs.findbugs.annotations.NonNull;
 import hudson.EnvVars;
 import hudson.Extension;
 import hudson.FilePath;
@@ -69,7 +70,6 @@
 import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
-import javax.annotation.Nonnull;
 import jenkins.model.Jenkins;
 import net.sf.json.JSONObject;
 import org.jenkinsci.Symbol;
@@ -249,7 +249,7 @@ public JiraTestDataPublisher(
      */
     @Override
     public TestResultAction.Data contributeTestData(
-            Run<?, ?> run, @Nonnull FilePath workspace, Launcher launcher, TaskListener listener, TestResult testResult)
+            Run<?, ?> run, @NonNull FilePath workspace, Launcher launcher, TaskListener listener, TestResult testResult)
             throws IOException, InterruptedException {
 
         EnvVars envVars = run.getEnvironment(listener);
@@ -795,6 +795,10 @@ public FormValidation validateFieldConfigs(String jsonForm) throws FormException
                 }
             }
 
+            if (jiraPublisherJSON == null) {
+                return FormValidation.error("jiraPublisherJSON is null.\n");
+            }
+
             // constructing the objects from json
             List<AbstractFields> configs =
                     newInstancesFromHeteroList(req, jiraPublisherJSON.get("configs"), getListDescriptors());

diff --git a/src/main/java/org/jenkinsci/plugins/JiraTestResultReporter/JobConfigMapping.java b/src/main/java/org/jenkinsci/plugins/JiraTestResultReporter/JobConfigMapping.java
@@ -394,6 +394,9 @@ public synchronized void saveConfig(
      * Method for setting the last configuration made for a project
      */
     public synchronized void saveConfig(Job project, JobConfigEntry entry) {
+        if (project == null) {
+            return;
+        }
         if (entry instanceof JobConfigEntryBuilder) {
             entry = ((JobConfigEntryBuilder) entry).build();
         }

diff --git a/src/main/java/org/jenkinsci/plugins/JiraTestResultReporter/TestToIssueMapping.java b/src/main/java/org/jenkinsci/plugins/JiraTestResultReporter/TestToIssueMapping.java
@@ -154,6 +154,10 @@ private HashMap<String, String> loadMap(Job job) {
      * @param job
      */
     public void register(Job job) {
+        if (job == null) {
+            return;
+        }
+
         if (job instanceof MatrixProject) {
             for (Job child : ((MatrixProject) job).getAllJobs()) {
                 if (child instanceof MatrixProject) {