Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump BOM fo fix JUnit issues #147

Merged
merged 3 commits into from
Sep 9, 2024
Merged

Bump BOM fo fix JUnit issues #147

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2d0f00d
Bump BOM fo fix JUnit issues
imonteroperez Sep 9, 2024
3ac6be1
Fix enforcer rules
imonteroperez Sep 9, 2024
a957a59
Temporary ignore spotbugs issues
imonteroperez Sep 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,17 +6,17 @@
<groupId>org.jenkins-ci.plugins</groupId>
<artifactId>plugin</artifactId>
<!-- Baseline Jenkins version you use to build and test the plugin. Users must have this version or newer to run. -->
<version>4.31</version>
<version>4.87</version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to clean up SpotBugs violations.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pro tip: setting <spotbugs.threshold>High</spotbugs.threshold> will reduce the number of SpotBugs violations.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added ignores ATM to move forward and tracked in #148 the removal of the issues

<relativePath />
</parent>

<properties>
<changelist>999999-SNAPSHOT</changelist>
<jenkins.version>2.321</jenkins.version>
<jira-rest-client.version>5.2.2</jira-rest-client.version>
<jenkins.version>2.462</jenkins.version>
<jira-rest-client.version>5.2.6</jira-rest-client.version>
<fugue.version>3.0.0</fugue.version>
<spotbugs.failOnError>false</spotbugs.failOnError>
<java.level>8</java.level>
<java.level>11</java.level>
<gitHubRepo>jenkinsci/${project.artifactId}-plugin</gitHubRepo>
</properties>

Expand Down Expand Up @@ -118,8 +118,8 @@
<dependencies>
<dependency>
<groupId>io.jenkins.tools.bom</groupId>
<artifactId>bom-2.319.x</artifactId>
<version>1013.vf8058992a042</version>
<artifactId>bom-2.462.x</artifactId>
<version>3334.v18e2a_2f48356</version>
<scope>import</scope>
<type>pom</type>
</dependency>
Expand Down Expand Up @@ -156,6 +156,10 @@
<artifactId>jira-rest-java-client-core</artifactId>
<version>${jira-rest-client.version}</version>
<exclusions>
<exclusion>
<groupId>org.apache.commons</groupId>
<artifactId>commons-lang3</artifactId>
</exclusion>
<exclusion>
<groupId>com.google.guava</groupId>
<artifactId>guava</artifactId>
Expand Down
Loading