Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid calling ClassResult.getChildren from tests #129

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Avoid calling ClassResult.getChildren from tests #129

merged 1 commit into from
Jul 24, 2024

Conversation

jglick
Copy link
Member

@jglick jglick commented Jul 23, 2024

Fixing #127, superseding #128. jenkinsci/junit-plugin#625 (comment)

javap before:

22: invokevirtual #96                 // Method hudson/tasks/junit/ClassResult.getChildren:()Ljava/util/List;

After:

22: invokevirtual #96                 // Method hudson/tasks/test/TabulatedResult.getChildren:()Ljava/util/Collection;

@jglick jglick requested a review from a team as a code owner July 23, 2024 16:56
@jglick jglick requested a review from timja July 23, 2024 16:56
@jglick jglick mentioned this pull request Jul 23, 2024
Merged
12 tasks
@timja timja merged commit 9e003ac into jenkinsci:main Jul 24, 2024
16 checks passed
@jglick jglick deleted the getChildren branch July 24, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonesbusy jonesbusy jonesbusy approved these changes

@timja timja Awaiting requested review from timja

Assignees
No one assigned
Labels
developer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jglick @jonesbusy @timja