Restore compatiblity with junit-sql-storage #630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timja
commented
Jul 29, 2024
| durationColor.put("value", duration); | ||
| if (to.isPassed() || (to.getPassCount() > 0 && to.getFailCount() == 0)) { |
There was a problem hiding this comment.
minor behaviour change here but should be safe enough
|
|
||
| public HistoryTestResultSummary(Run<?, ?> run, hudson.tasks.test.TestResult resultInRun, | ||
| public HistoryTestResultSummary(Run<?, ?> run, |
There was a problem hiding this comment.
this was the critical change, adding resultInRun broke the plugin and I can't see a way to retrieve it there. The API could be modified to maybe pass some more info down but it didn't seem necessary the only additional information that is missing now is the id of the test report which could be stored maybe if required
| @@ -476,7 +476,7 @@ public List<HistoryTestResultSummary> getHistorySummary(int offset) { | |||
| Job<?, ?> theJob = Jenkins.get().getItemByFullName(getJobName(), Job.class); | |||
| if (theJob != null) { | |||
| Run<?, ?> run = theJob.getBuildByNumber(buildNumber); | |||
| historyTestResultSummaries.add(new HistoryTestResultSummary(run, null, duration, failed, skipped, passed)); | |||
There was a problem hiding this comment.
this shouldn't have had null passed as it made the test run but if any one actually tried to access the history view they got null pointers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and some minor cleanup at the same time, bunch of unused variables mostly.
Also fixed clicking on builds in the charts, variable wasn't defined properly before
cc @mdealer
noticed in jenkinsci/junit-sql-storage-plugin#430
caused by #625
Testing done
manually tested both junit and junit-sql-storage
Submitter checklist