Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-73943] Remove legacy checkUrl usage in AggregatedTestResutPublisher/config.jelly #657

Merged
merged 1 commit into from
Oct 16, 2024
Merged

[JENKINS-73943] Remove legacy checkUrl usage in AggregatedTestResutPublisher/config.jelly #657

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/hudson/tasks/test/AggregatedTestResultPublisher.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,7 +370,7 @@
return Messages.AggregatedTestResultPublisher_DisplayName();
}

public FormValidation doCheck(@AncestorInPath AbstractProject project, @QueryParameter String value) {
public FormValidation doCheckJobs(@AncestorInPath AbstractProject project, @QueryParameter String value) {

Check warning

Code scanning / Jenkins Security Scan

Stapler: Missing POST/RequirePOST annotation Warning test

Potential CSRF vulnerability: If DescriptorImpl#doCheckJobs connects to user-specified URLs, modifies state, or is expensive to run, it should be annotated with @POST or @RequirePOST
// Require CONFIGURE permission on this project
if (!project.hasPermission(Item.CONFIGURE)) {
return FormValidation.ok();
Expand Down
1 change: 0 additions & 1 deletion src/main/resources/hudson/tasks/test/AggregatedTestResultPublisher/config.jelly
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ THE SOFTWARE.
<f:entry title="${%Jobs to aggregate}"
help="/descriptorByName/hudson.tasks.test.AggregatedTestResultPublisher/help/manual-list">
<f:textbox name="aggregatedTestResult.jobs" value="${instance.jobs}"
checkUrl="'descriptorByName/hudson.tasks.test.AggregatedTestResultPublisher/check?value='+encodeURIComponent(this.value)"
field="jobs"
autoCompleteDelimChar="," />
</f:entry>
Expand Down