Use Sauce Connect 5 #201
Merged
Use Sauce Connect 5 #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
alexh-sauce
commented
Nov 1, 2024
alexh-sauce
commented
- Adds Sauce Connect 5
- Bumps various dependencies for sauceREST and ci-sauce
alexh-sauce
force-pushed
the
alexh-sc-5
branch
6 times, most recently
from
8d7ae0a to
560705d
Compare
This was referenced Nov 5, 2024
alexh-sauce
force-pushed
the
alexh-sc-5
branch
2 times, most recently
from
a8f2848 to
84105d0
Compare
mmatczuk
reviewed
Nov 6, 2024
| @@ -191,6 +191,16 @@ public class SauceOnDemandBuildWrapper extends BuildWrapper implements Serializa | |||
| /** Indicates whether Sauce Connect should be started as part of the build. */ | |||
| private boolean enableSauceConnect; | |||
|
|
|||
| private static Map<String, String> endpointToRegion = new HashMap<>(); | |||
|
I do not get how it works, we added moshi and okio but I do not see them being used. What happens here? |
|
It's used here, but previously the dependency was included in SauceREST: saucelabs/saucerest-java@de9d22d |
This was removed in saucerest but is still needed for tests here.
alexh-sauce
force-pushed
the
alexh-sc-5
branch
from
84105d0 to
6e7d8fa
Compare
This is implemented in the parent class already.
alexh-sauce
force-pushed
the
alexh-sc-5
branch
from
6e7d8fa to
5ad0b00
Compare
|
LGTM |
alexh-sauce
added a commit
to saucelabs/jenkins-sauce-ondemand-plugin
that referenced
this pull request
Nov 14, 2024
alexh-sauce
added a commit
that referenced
this pull request
Nov 14, 2024
Revert "Merge pull request #201 from saucelabs/alexh-sc-5"
alexh-sauce
added a commit
to saucelabs/jenkins-sauce-ondemand-plugin
that referenced
this pull request
Nov 15, 2024
…-sc-5"" This reverts commit 7c299c5.
alexh-sauce
added a commit
that referenced
this pull request
Nov 15, 2024
Revert "Revert "Merge pull request #201 from saucelabs/alexh-sc-5""
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.