Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-74147] Extract inline JS script in SauceOnDemandBuildWrapper/config.jelly #213

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

shlomomdahan
Copy link
Contributor

@shlomomdahan shlomomdahan commented Dec 10, 2024

JENKINS-74147

Why
https://www.jenkins.io/blog/2024/10/04/content-security-policy-grant/

Extract in JS script in SauceOnDemandBuildWrapper/config.jelly

Testing done

Before Changes:
https://github.com/user-attachments/assets/28dfcd14-9e33-4610-931e-024c478f980a

After Changes: (no More CSP violation - breakpoints correctly triggered.)
https://github.com/user-attachments/assets/2d23a2bf-e0f4-4133-8944-f8367cc7cf20

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@alexh-sauce alexh-sauce merged commit 29c741c into jenkinsci:master Dec 12, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants