Fix for loop bug which breaks favicon replacement (#171)

* create static array from htmlcollection
jenkinsci · Nov 9, 2023 · 0da3393 · 0da3393
1 parent 1d73700
commit 0da3393
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/main/webapp/simple-theme.js b/src/main/webapp/simple-theme.js
@@ -2,7 +2,7 @@
     "use strict";
 
     function removeAll() {
-        var links = document.getElementsByTagName('link'),
+        var links = Array.from(document.getElementsByTagName('link')),
             link, i;
 
         for (i = 0; i < links.length; i++) {
@@ -30,4 +30,4 @@
     global['org.jenkinsci.plugins.simpletheme'] = {
         replaceFavicon: replaceFavicon
     };
-})(this, document);
+})(this, document);