ta: storage: fix ta_storage_cmd_key_in_persistent() cleanup

Fixes the error cleanup path in two places where a created test object was supposed to be removed. Fixes: 90f2335 ("Test Persistent Object with keys") Signed-off-by: Jens Wiklander <[email protected]> Reviewed-by: Jerome Forissier <[email protected]> Reviewed-by: Etienne Carriere <[email protected]>
jenswi-linaro · Nov 30, 2023 · 23a404d · 23a404d
1 parent e18381f
commit 23a404d
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/ta/storage/storage.c b/ta/storage/storage.c
@@ -487,7 +487,7 @@ TEE_Result ta_storage_cmd_key_in_persistent(uint32_t param_types,
 	result = check_obj(&keyInfo, &keyInfo2);
 	if (result != TEE_SUCCESS) {
 		EMSG("keyInfo and keyInfo2 are different");
-		goto cleanup2;
+		goto cleanup3;
 	}
 
 	TEE_CloseObject(persistent_key);
@@ -504,7 +504,7 @@ TEE_Result ta_storage_cmd_key_in_persistent(uint32_t param_types,
 	result = check_obj(&keyInfo3, &keyInfo2);
 	if (result != TEE_SUCCESS) {
 		EMSG("keyInfo2 and keyInfo3 are different");
-		goto cleanup2;
+		goto cleanup3;
 	}
 
 	result = TEE_AllocateOperation(&encrypt_op, alg, TEE_MODE_ENCRYPT,