Fix for (undefined) NODEJS_LTS_API 20

jeroen · Oct 12, 2024 · 9215ec2 · 9215ec2
1 parent 679e5e0
commit 9215ec2
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/src/bindings.cpp b/src/bindings.cpp
@@ -10,15 +10,15 @@
 #define NODEJS_LTS_API 18
 #elif V8_MAJOR_VERSION == 9
 #define NODEJS_LTS_API 16
-#elif V8_MAJOR_VERSION == 8
+#elif V8_MAJOR_VERSION < 9
 #define NODEJS_LTS_API 14
 #endif
 #endif
 
-#if !defined(ISNODEJS) || NODEJS_LTS_API > 16
-#define FixedArrayParam ,v8::Local<v8::FixedArray> import_arributes
-#else
+#if defined(NODEJS_LTS_API) && NODEJS_LTS_API < 18
 #define FixedArrayParam
+#else
+#define FixedArrayParam ,v8::Local<v8::FixedArray> import_arributes
 #endif
 
 #if V8_VERSION_TOTAL < 803
@@ -129,11 +129,11 @@ static v8::MaybeLocal<v8::Promise> ResolveDynamicModuleCallback(
 }
 
 static v8::ScriptOrigin make_origin(std::string filename){
-#if defined(ISNODEJS) && NODEJS_LTS_API < 18
+#if defined(NODEJS_LTS_API) && NODEJS_LTS_API < 18
   return v8::ScriptOrigin(ToJSString( filename.c_str()), v8::Integer::New(isolate, 0),
                           v8::Integer::New(isolate, 0), v8::False(isolate), v8::Local<v8::Integer>(),
                           v8::Local<v8::Value>(), v8::False(isolate), v8::False(isolate), v8::True(isolate));
-#elif V8_VERSION_TOTAL < 1201
+#elif V8_VERSION_TOTAL < 1201 || NODEJS_LTS_API == 20
   return v8::ScriptOrigin(isolate,ToJSString( filename.c_str()), 0, 0, false, -1,
                           v8::Local<v8::Value>(), false, false, true);
 #else