Fix memory leak

jerson · Sep 20, 2021 · 6b39139 · 6b39139
1 parent 183b9c1
commit 6b39139
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/proto/http.go b/proto/http.go
@@ -53,10 +53,13 @@ func NewHttp() *Http {
 	}
 }
 
-func extractBody(r io.Reader) ([]byte, io.ReadCloser, error) {
+func extractBody(r io.ReadCloser) ([]byte, io.ReadCloser, error) {
 	buf := new(bytes.Buffer)
-	_, err := buf.ReadFrom(r)
-	return buf.Bytes(), ioutil.NopCloser(buf), err
+	// copied from https://github.com/xinxin8816/ngrok/commit/3463565536ab417d7c0a1d4b6cf5a073c128f944
+	//_, err := buf.ReadFrom(r)
+	defer r.Close()
+	//return buf.Bytes(), ioutil.NopCloser(buf), err
+	return buf.Bytes(), nil, nil
 }
 
 func (h *Http) GetName() string { return "http" }