Simplify handling of multiple WizMotes #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LSB(yte) first also known as Little Endian (LE) Ensure WiZMote packet data struct is packed Remove unnecessary parens
jesserockz
approved these changes
Oct 26, 2023
|
@jesserockz Will this pull request be merged? It was approved over a year ago. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using a fixed array with a linear lookup and manual shuffling of data, I'm tracking the last seen sequence number using standard map.
This simplifies the application code quite a bit. Additionally there is no restriction on the number of WizMotes.
This branch is built on top of my other PR #15, so if this PR is acceptable you can close the other.
Tested and confirmed working with an ESP32.