Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cleanup main types #1675

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

MichaelDeBoey
Copy link
Contributor

Follow-up of #1667

CC/ @G-Rath @mskelton

@G-Rath
Copy link
Collaborator

G-Rath commented Nov 20, 2024

I don't really see this as strictly better - the types as they are pretty straightforward and maintainable as they are imo, and I in particular like having the configs written out individually to make it clear what is available without having to mentally unroll some type logic.

At the very least, this is not a "feat" or a "fix"

@mskelton
Copy link
Contributor

I would agree with @G-Rath on this not necessarily improving the types greatly.

@MichaelDeBoey
Copy link
Contributor Author

@G-Rath @mskelton We're also using TSESLint's types here, which is a dependency we already have

If we use ESLint's dependency, we would need to add @types/eslint to the dependencies in package.json to work correctly

@G-Rath
Copy link
Collaborator

G-Rath commented Nov 20, 2024

@MichaelDeBoey you'll already need @types/eslint as a dependency if you're type-checking eslint.config.js on v8, and ESLint v9 ships with its own types that are compatible with these ones, so that shouldn't be an issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants