Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ACR JWT #290

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix ACR JWT #290

wants to merge 2 commits into from

Conversation

roelarents
Copy link

Fixes two issues with ACR authz:

  1. JWT parsing didn't supply a keyfunc to verify the JWT access token, but that is required. Added a cli-option to supply a JWKS URI. Which is by default empty and then JWT verification is explicitly skipped.
  2. When using Basic authz, it is still required to obtain an access token first with which to make requests for manifests and tags.

@hawksight
Copy link
Contributor

Thank you @roelarents for this and several other PRs recently. We may not be able to fully review this very quickly. I'll attempt to give it a good look over in the next week or two.

Can you give any context whether you've built and run this change in your environment?

@roelarents
Copy link
Author

Thanks in advance. I've merged them, built the image, and ran it in our test k8s environment which uses a docker.io and aprivate.azurecr.io registry with basic auth.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants