Fixes #12313 - Jetty 12 ee9/ee10 doesn't invoke callbacks when h2 client sends RST_STREAM. #12370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sbordet
commented
Oct 10, 2024
sbordet
commented
- Fixed invocation of AsyncListener.onError(), now called even if the response is already committed, in both EE9 and EE10.
- Reworked EE9 HttpChannel state machine in case of failures to be like EE10's. In particular, calling abort now is a state change, rather than a failure of the Handler callback. In this way, the handle() loop continues, enters case TERMINATED, and the callback is completed in onCompleted().
- Fixed EE9 handling of idle timeout in HttpChannel.onRequest(), that was missing.
…ent sends RST_STREAM. * Fixed invocation of AsyncListener.onError(), now called even if the response is already committed, in both EE9 and EE10. * Reworked EE9 HttpChannel state machine in case of failures to be like EE10's. In particular, calling abort now is a state change, rather than a failure of the Handler callback. In this way, the handle() loop continues, enters case TERMINATED, and the callback is completed in onCompleted(). * Fixed EE9 handling of idle timeout in HttpChannel.onRequest(), that was missing. Signed-off-by: Simone Bordet <[email protected]>
…ent sends RST_STREAM. * Removed unnecessary calls to EE9's `HttpChannel.abort()`. Signed-off-by: Simone Bordet <[email protected]>
…ent sends RST_STREAM. * Do not recycle EE9 HttpChannel for WebSocket requests. * Simplified sendError() error handling. Signed-off-by: Simone Bordet <[email protected]>
|
Is there a chance this will land in 12.0.15? |
|
@wendigo it's very likely that this PR gets merged before 12.0.15 gets released. |
lorban
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.