Skip to content

Commit

Permalink
fix: removed irrelevant TODOs
Browse files Browse the repository at this point in the history
  • Loading branch information
jeroenrinzema committed Oct 7, 2020
1 parent 185f7ed commit eed88a8
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 2 deletions.
1 change: 0 additions & 1 deletion pkg/lookup/lookup.go
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,6 @@ func ParamsLookup(params map[string]*specs.Property, flow specs.FlowInterface, b

result := reference.Clone()

// TODO: needs refactoring
if param.Scalar != nil && result.Scalar != nil {
param.Scalar.Type = result.Scalar.Type
}
Expand Down
1 change: 0 additions & 1 deletion pkg/specs/template/template.go
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,6 @@ func ParsePropertyReference(value string) *specs.PropertyReference {

// ParseReference parses the given value as a template reference
func ParseReference(path string, name string, value string) (*specs.Property, error) {
// TODO: check values
if strings.Count(value, "..") > 0 {
return nil, ErrPathNotFound{
Path: value,
Expand Down

0 comments on commit eed88a8

Please sign in to comment.